Browse Source

feat: implements isActive checkbox

pull/4497/head
tobikugel 3 weeks ago
parent
commit
4cd2502cf8
  1. 2
      apps/api/src/app/admin/admin.service.ts
  2. 5
      apps/api/src/app/admin/update-asset-profile.dto.ts
  3. 1
      apps/api/src/app/import/import.service.ts
  4. 18
      apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts
  5. 11
      apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html
  6. 2
      apps/client/src/app/services/admin.service.ts
  7. 1
      libs/common/src/lib/interfaces/enhanced-symbol-profile.interface.ts

2
apps/api/src/app/admin/admin.service.ts

@ -480,6 +480,7 @@ export class AdminService {
currency, currency,
dataSource: newDataSource, dataSource: newDataSource,
holdings, holdings,
isActive,
name, name,
scraperConfiguration, scraperConfiguration,
sectors, sectors,
@ -557,6 +558,7 @@ export class AdminService {
currency, currency,
dataSource, dataSource,
holdings, holdings,
isActive,
scraperConfiguration, scraperConfiguration,
sectors, sectors,
symbol, symbol,

5
apps/api/src/app/admin/update-asset-profile.dto.ts

@ -3,6 +3,7 @@ import { IsCurrencyCode } from '@ghostfolio/api/validators/is-currency-code';
import { AssetClass, AssetSubClass, DataSource, Prisma } from '@prisma/client'; import { AssetClass, AssetSubClass, DataSource, Prisma } from '@prisma/client';
import { import {
IsArray, IsArray,
IsBoolean,
IsEnum, IsEnum,
IsObject, IsObject,
IsOptional, IsOptional,
@ -35,6 +36,10 @@ export class UpdateAssetProfileDto {
@IsOptional() @IsOptional()
dataSource?: DataSource; dataSource?: DataSource;
@IsBoolean()
@IsOptional()
isActive?: boolean;
@IsString() @IsString()
@IsOptional() @IsOptional()
name?: string; name?: string;

1
apps/api/src/app/import/import.service.ts

@ -546,6 +546,7 @@ export class ImportService {
SymbolProfile: { SymbolProfile: {
currency, currency,
dataSource, dataSource,
isActive: false,
symbol, symbol,
activitiesCount: undefined, activitiesCount: undefined,
assetClass: undefined, assetClass: undefined,

18
apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts

@ -34,6 +34,7 @@ import {
ValidationErrors, ValidationErrors,
Validators Validators
} from '@angular/forms'; } from '@angular/forms';
import { MatCheckboxChange } from '@angular/material/checkbox';
import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog'; import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
import { MatSnackBar } from '@angular/material/snack-bar'; import { MatSnackBar } from '@angular/material/snack-bar';
import { import {
@ -79,6 +80,7 @@ export class AssetProfileDialog implements OnDestroy, OnInit {
historicalData: this.formBuilder.group({ historicalData: this.formBuilder.group({
csvString: '' csvString: ''
}), }),
isActive: [false],
name: ['', Validators.required], name: ['', Validators.required],
scraperConfiguration: this.formBuilder.group({ scraperConfiguration: this.formBuilder.group({
defaultMarketPrice: null, defaultMarketPrice: null,
@ -227,6 +229,7 @@ export class AssetProfileDialog implements OnDestroy, OnInit {
historicalData: { historicalData: {
csvString: AssetProfileDialog.HISTORICAL_DATA_TEMPLATE csvString: AssetProfileDialog.HISTORICAL_DATA_TEMPLATE
}, },
isActive: this.assetProfile?.isActive,
name: this.assetProfile.name ?? this.assetProfile.symbol, name: this.assetProfile.name ?? this.assetProfile.symbol,
scraperConfiguration: { scraperConfiguration: {
defaultMarketPrice: defaultMarketPrice:
@ -442,6 +445,7 @@ export class AssetProfileDialog implements OnDestroy, OnInit {
assetSubClass: this.assetProfileForm.get('assetSubClass').value, assetSubClass: this.assetProfileForm.get('assetSubClass').value,
comment: this.assetProfileForm.get('comment').value || null, comment: this.assetProfileForm.get('comment').value || null,
currency: this.assetProfileForm.get('currency').value, currency: this.assetProfileForm.get('currency').value,
isActive: this.assetProfileForm.get('isActive').value,
name: this.assetProfileForm.get('name').value, name: this.assetProfileForm.get('name').value,
url: this.assetProfileForm.get('url').value || null url: this.assetProfileForm.get('url').value || null
}; };
@ -523,6 +527,20 @@ export class AssetProfileDialog implements OnDestroy, OnInit {
}); });
} }
public onToggleIsActive(event: MatCheckboxChange) {
if (event.checked) {
this.assetProfileForm.get('isActive')?.setValue(true);
} else {
this.assetProfileForm.get('isActive')?.setValue(false);
}
event.checked === this.assetProfile.isActive
? this.assetProfileForm.get('isActive')?.markAsPristine()
: this.assetProfileForm.get('isActive')?.markAsDirty();
this.changeDetectorRef.detectChanges();
}
public onUnsetBenchmark({ dataSource, symbol }: AssetProfileIdentifier) { public onUnsetBenchmark({ dataSource, symbol }: AssetProfileIdentifier) {
this.dataService this.dataService
.deleteBenchmark({ dataSource, symbol }) .deleteBenchmark({ dataSource, symbol })

11
apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@ -509,7 +509,16 @@
</form> </form>
</div> </div>
<div class="d-flex justify-content-end" mat-dialog-actions> <div class="d-flex" mat-dialog-actions>
<mat-checkbox
class="gf-spacer"
color="primary"
[checked]="assetProfile?.isActive ?? false"
[disabled]="isEditAssetProfileIdentifierMode"
(change)="onToggleIsActive($event)"
>
<ng-container i18n>Active</ng-container>
</mat-checkbox>
<button i18n mat-button type="button" (click)="onClose()">Cancel</button> <button i18n mat-button type="button" (click)="onClose()">Cancel</button>
<button <button
color="primary" color="primary"

2
apps/client/src/app/services/admin.service.ts

@ -212,6 +212,7 @@ export class AdminService {
countries, countries,
currency, currency,
dataSource: newDataSource, dataSource: newDataSource,
isActive,
name, name,
scraperConfiguration, scraperConfiguration,
sectors, sectors,
@ -229,6 +230,7 @@ export class AdminService {
countries, countries,
currency, currency,
dataSource: newDataSource, dataSource: newDataSource,
isActive,
name, name,
scraperConfiguration, scraperConfiguration,
sectors, sectors,

1
libs/common/src/lib/interfaces/enhanced-symbol-profile.interface.ts

@ -22,6 +22,7 @@ export interface EnhancedSymbolProfile {
figiShareClass?: string; figiShareClass?: string;
holdings: Holding[]; holdings: Holding[];
id: string; id: string;
isActive: boolean;
isin?: string; isin?: string;
name?: string; name?: string;
scraperConfiguration?: ScraperConfiguration; scraperConfiguration?: ScraperConfiguration;

Loading…
Cancel
Save