From 4da488cf3d94d83005ba5424d924a520329d0162 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Wed, 30 Apr 2025 17:21:54 +0200 Subject: [PATCH] Refactoring --- .../create-or-update-activity-dialog.component.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts index c0b4bae27..dce045a4a 100644 --- a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts @@ -220,7 +220,7 @@ export class CreateOrUpdateActivityDialog implements OnDestroy { .get('type') .valueChanges.pipe(takeUntil(this.unsubscribeSubject)) .subscribe((type: Type) => { - if (['ITEM'].includes(type)) { + if (type === 'ITEM') { this.activityForm .get('accountId') .removeValidators(Validators.required); @@ -274,7 +274,7 @@ export class CreateOrUpdateActivityDialog implements OnDestroy { this.activityForm.get('name').setValidators(Validators.required); this.activityForm.get('name').updateValueAndValidity(); - if (['FEE'].includes(type)) { + if (type === 'FEE') { this.activityForm.get('quantity').setValue(0); } else if (['INTEREST', 'LIABILITY'].includes(type)) { this.activityForm.get('quantity').setValue(1); @@ -285,7 +285,7 @@ export class CreateOrUpdateActivityDialog implements OnDestroy { .removeValidators(Validators.required); this.activityForm.get('searchSymbol').updateValueAndValidity(); - if (['FEE'].includes(type)) { + if (type === 'FEE') { this.activityForm.get('unitPrice').setValue(0); }