From 50751d3eb9798ba7379a8f05a047b283cab20491 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20TISON?= <13355624+Airthee@users.noreply.github.com> Date: Sun, 5 Apr 2026 09:08:53 +0200 Subject: [PATCH] Task/show loading state on activities type filter change (#6677) * Show loading state on activities type filter change --------- Co-authored-by: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> --- .../activities/activities-page.component.ts | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts b/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts index faadef54f..acd6cba10 100644 --- a/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts @@ -65,7 +65,7 @@ export class GfActivitiesPageComponent implements OnInit { public routeQueryParams: Subscription; public sortColumn = 'date'; public sortDirection: SortDirection = 'desc'; - public totalItems: number; + public totalItems: number | undefined; public user: User; public constructor( @@ -135,8 +135,11 @@ export class GfActivitiesPageComponent implements OnInit { } public fetchActivities() { - const dateRange = this.user?.settings?.dateRange; + // Reset dataSource and totalItems to show loading state + this.dataSource = undefined; + this.totalItems = undefined; + const dateRange = this.user?.settings?.dateRange; const range = this.isCalendarYear(dateRange) ? dateRange : undefined; this.dataService @@ -200,6 +203,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe(); this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); }); } @@ -214,6 +219,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe(); this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); }); } @@ -289,6 +296,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe(); this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); }); } @@ -316,6 +325,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe(); this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); }); } @@ -365,6 +376,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe({ next: () => { this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); } }); } @@ -422,6 +435,8 @@ export class GfActivitiesPageComponent implements OnInit { .subscribe(); this.fetchActivities(); + + this.changeDetectorRef.markForCheck(); } }); }