Clean up

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -78,10 +78,8 @@ export class PortfolioController {
     @Query('assetClasses') filterByAssetClasses?: string,
     @Query('range') dateRange: DateRange = 'max',
     @Query('tags') filterByTags?: string,
-    @Query('withLiabilities') withLiabilitiesParam = 'false',
     @Query('withMarkets') withMarketsParam = 'false'
   ): Promise<PortfolioDetails & { hasError: boolean }> {
-    const withLiabilities = withLiabilitiesParam === 'true';
     const withMarkets = withMarketsParam === 'true';
 
     let hasDetails = true;
@@ -107,8 +105,6 @@ export class PortfolioController {
         dateRange,
         filters,
         impersonationId,
-        // TODO
-        // withLiabilities,
         withMarkets,
         userId: this.request.user.id,
         withSummary: true

apps/api/src/app/portfolio/portfolio.service.ts

@@ -323,7 +323,6 @@ export class PortfolioService {
     impersonationId,
     userId,
     withExcludedAccounts = false,
-    withLiabilities = false,
     withMarkets = false,
     withSummary = false
   }: {
@@ -332,7 +331,6 @@ export class PortfolioService {
     impersonationId: string;
     userId: string;
     withExcludedAccounts?: boolean;
-    withLiabilities?: boolean;
     withMarkets?: boolean;
     withSummary?: boolean;
   }): Promise<PortfolioDetails & { hasErrors: boolean }> {

apps/client/src/app/components/home-summary/home-summary.component.ts

@@ -102,7 +102,7 @@ export class HomeSummaryComponent implements OnDestroy, OnInit {
     this.isLoading = true;
 
     this.dataService
-      .fetchPortfolioDetails({ withLiabilities: true })
+      .fetchPortfolioDetails()
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe(({ summary }) => {
         this.summary = summary;

apps/client/src/app/services/data.service.ts

@@ -411,19 +411,13 @@ export class DataService {
 
   public fetchPortfolioDetails({
     filters,
-    withLiabilities = false,
     withMarkets = false
   }: {
     filters?: Filter[];
-    withLiabilities?: boolean;
     withMarkets?: boolean;
   } = {}): Observable<PortfolioDetails> {
     let params = this.buildFiltersAsQueryParams({ filters });
 
-    if (withLiabilities) {
-      params = params.append('withLiabilities', withLiabilities);
-    }
-
     if (withMarkets) {
       params = params.append('withMarkets', withMarkets);
     }