From 50bbaf875b96df7ba1685a07e552f6ed349089fd Mon Sep 17 00:00:00 2001 From: KenTandrian Date: Sat, 15 Nov 2025 11:19:24 +0700 Subject: [PATCH] feat(lib): move UpdateMarketDataDto to common lib --- .../app/admin/update-bulk-market-data.dto.ts | 4 ++-- .../update-bulk-market-data.dto.ts | 19 +++---------------- .../market-data/market-data.service.ts | 2 +- libs/common/src/lib/dtos/index.ts | 2 ++ .../src/lib/dtos}/update-market-data.dto.ts | 0 ...historical-market-data-editor.component.ts | 2 +- 6 files changed, 9 insertions(+), 20 deletions(-) rename {apps/api/src/app/admin => libs/common/src/lib/dtos}/update-market-data.dto.ts (100%) diff --git a/apps/api/src/app/admin/update-bulk-market-data.dto.ts b/apps/api/src/app/admin/update-bulk-market-data.dto.ts index da0da1272..f92112f24 100644 --- a/apps/api/src/app/admin/update-bulk-market-data.dto.ts +++ b/apps/api/src/app/admin/update-bulk-market-data.dto.ts @@ -1,8 +1,8 @@ +import { UpdateMarketDataDto } from '@ghostfolio/common/dtos'; + import { Type } from 'class-transformer'; import { ArrayNotEmpty, IsArray } from 'class-validator'; -import { UpdateMarketDataDto } from './update-market-data.dto'; - export class UpdateBulkMarketDataDto { @ArrayNotEmpty() @IsArray() diff --git a/apps/api/src/app/endpoints/market-data/update-bulk-market-data.dto.ts b/apps/api/src/app/endpoints/market-data/update-bulk-market-data.dto.ts index d07b189b2..f92112f24 100644 --- a/apps/api/src/app/endpoints/market-data/update-bulk-market-data.dto.ts +++ b/apps/api/src/app/endpoints/market-data/update-bulk-market-data.dto.ts @@ -1,11 +1,7 @@ +import { UpdateMarketDataDto } from '@ghostfolio/common/dtos'; + import { Type } from 'class-transformer'; -import { - ArrayNotEmpty, - IsArray, - IsISO8601, - IsNumber, - IsOptional -} from 'class-validator'; +import { ArrayNotEmpty, IsArray } from 'class-validator'; export class UpdateBulkMarketDataDto { @ArrayNotEmpty() @@ -13,12 +9,3 @@ export class UpdateBulkMarketDataDto { @Type(() => UpdateMarketDataDto) marketData: UpdateMarketDataDto[]; } - -class UpdateMarketDataDto { - @IsISO8601() - @IsOptional() - date?: string; - - @IsNumber() - marketPrice: number; -} diff --git a/apps/api/src/services/market-data/market-data.service.ts b/apps/api/src/services/market-data/market-data.service.ts index d318b9a70..87b08e1bd 100644 --- a/apps/api/src/services/market-data/market-data.service.ts +++ b/apps/api/src/services/market-data/market-data.service.ts @@ -1,7 +1,7 @@ -import { UpdateMarketDataDto } from '@ghostfolio/api/app/admin/update-market-data.dto'; import { DateQuery } from '@ghostfolio/api/app/portfolio/interfaces/date-query.interface'; import { DataGatheringItem } from '@ghostfolio/api/services/interfaces/interfaces'; import { PrismaService } from '@ghostfolio/api/services/prisma/prisma.service'; +import { UpdateMarketDataDto } from '@ghostfolio/common/dtos'; import { resetHours } from '@ghostfolio/common/helper'; import { AssetProfileIdentifier } from '@ghostfolio/common/interfaces'; diff --git a/libs/common/src/lib/dtos/index.ts b/libs/common/src/lib/dtos/index.ts index 8eea137d5..bb3a970af 100644 --- a/libs/common/src/lib/dtos/index.ts +++ b/libs/common/src/lib/dtos/index.ts @@ -12,6 +12,7 @@ import { TransferBalanceDto } from './transfer-balance.dto'; import { UpdateAccessDto } from './update-access.dto'; import { UpdateAccountDto } from './update-account.dto'; import { UpdateAssetProfileDto } from './update-asset-profile.dto'; +import { UpdateMarketDataDto } from './update-market-data.dto'; import { UpdateOrderDto } from './update-order.dto'; import { UpdatePlatformDto } from './update-platform.dto'; import { UpdateTagDto } from './update-tag.dto'; @@ -32,6 +33,7 @@ export { UpdateAccessDto, UpdateAccountDto, UpdateAssetProfileDto, + UpdateMarketDataDto, UpdateOrderDto, UpdatePlatformDto, UpdateTagDto, diff --git a/apps/api/src/app/admin/update-market-data.dto.ts b/libs/common/src/lib/dtos/update-market-data.dto.ts similarity index 100% rename from apps/api/src/app/admin/update-market-data.dto.ts rename to libs/common/src/lib/dtos/update-market-data.dto.ts diff --git a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts index b36a70e69..f857e6e53 100644 --- a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts +++ b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts @@ -1,6 +1,6 @@ /* eslint-disable @nx/enforce-module-boundaries */ -import { UpdateMarketDataDto } from '@ghostfolio/api/app/admin/update-market-data.dto'; import { DataService } from '@ghostfolio/client/services/data.service'; +import { UpdateMarketDataDto } from '@ghostfolio/common/dtos'; import { DATE_FORMAT, getDateFormatString,