From 510551c115878b4c6ddca004d2179c3f12e7b92d Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Tue, 7 Sep 2021 22:00:49 +0200
Subject: [PATCH] Refactor isInteger

---
 .../position-detail-dialog.html                  |  2 --
 libs/ui/src/lib/value/value.component.stories.ts |  7 -------
 libs/ui/src/lib/value/value.component.ts         | 16 +++++-----------
 3 files changed, 5 insertions(+), 20 deletions(-)

diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
index 14cfb5ae5..939f0f4dc 100644
--- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
+++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
@@ -104,8 +104,6 @@
       <div class="col-6 mb-3">
         <gf-value
           size="medium"
-          [isCurrency]="false"
-          [isInteger]="true"
           [label]="transactionCount === 1 ? 'Transaction' : 'Transactions'"
           [locale]="data.locale"
           [value]="transactionCount"
diff --git a/libs/ui/src/lib/value/value.component.stories.ts b/libs/ui/src/lib/value/value.component.stories.ts
index 91c5f8fb5..8cd585de9 100644
--- a/libs/ui/src/lib/value/value.component.stories.ts
+++ b/libs/ui/src/lib/value/value.component.stories.ts
@@ -29,13 +29,6 @@ Currency.args = {
   value: 7
 };
 
-export const Integer = Template.bind({});
-Integer.args = {
-  isInteger: true,
-  locale: 'en-US',
-  value: 7
-};
-
 export const Label = Template.bind({});
 Label.args = {
   label: 'Label',
diff --git a/libs/ui/src/lib/value/value.component.ts b/libs/ui/src/lib/value/value.component.ts
index 16db5c021..fbe6c2878 100644
--- a/libs/ui/src/lib/value/value.component.ts
+++ b/libs/ui/src/lib/value/value.component.ts
@@ -18,12 +18,11 @@ export class ValueComponent implements OnChanges {
   @Input() colorizeSign = false;
   @Input() currency = '';
   @Input() isCurrency = false;
-  @Input() isInteger = false;
   @Input() isPercent = false;
   @Input() label = '';
   @Input() locale = '';
   @Input() position = '';
-  @Input() precision = 0;
+  @Input() precision: number | undefined;
   @Input() size = '';
   @Input() value: number | string = '';
 
@@ -83,20 +82,15 @@ export class ValueComponent implements OnChanges {
               minimumFractionDigits: 2
             });
           } catch {}
-        } else if (this.isInteger) {
+        } else if (this.precision || this.precision === 0) {
           try {
             this.formattedValue = this.value?.toLocaleString(this.locale, {
-              maximumFractionDigits: 0,
-              minimumFractionDigits: 0
+              maximumFractionDigits: this.precision,
+              minimumFractionDigits: this.precision
             });
           } catch {}
-        } else if (this.precision) {
-          this.formattedValue = this.value?.toLocaleString(this.locale, {
-            maximumFractionDigits: this.precision,
-            minimumFractionDigits: this.precision
-          });
         } else {
-          this.formattedValue = this.value.toString();
+          this.formattedValue = this.value?.toString();
         }
       } else {
         try {