From 542ca1c159ff5a0668e110079e4d48a1d6b4c658 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 30 Nov 2025 17:33:14 +0100
Subject: [PATCH] Refactoring

---
 apps/api/src/app/auth/oidc.strategy.ts             |  5 +++--
 .../configuration/configuration.service.ts         | 14 +++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/apps/api/src/app/auth/oidc.strategy.ts b/apps/api/src/app/auth/oidc.strategy.ts
index 6ed03b5a8..96b284121 100644
--- a/apps/api/src/app/auth/oidc.strategy.ts
+++ b/apps/api/src/app/auth/oidc.strategy.ts
@@ -47,8 +47,8 @@ export class OidcStrategy extends PassportStrategy(Strategy, 'oidc') {
         context?.claims?.sub;
 
       const jwt = await this.authService.validateOAuthLogin({
-        provider: Provider.OIDC,
-        thirdPartyId
+        thirdPartyId,
+        provider: Provider.OIDC
       });
 
       if (!thirdPartyId) {
@@ -56,6 +56,7 @@ export class OidcStrategy extends PassportStrategy(Strategy, 'oidc') {
           `Missing subject identifier in OIDC response from ${issuer}`,
           'OidcStrategy'
         );
+
         throw new Error('Missing subject identifier in OIDC response');
       }
 
diff --git a/apps/api/src/services/configuration/configuration.service.ts b/apps/api/src/services/configuration/configuration.service.ts
index 2a0546961..f31a8ca37 100644
--- a/apps/api/src/services/configuration/configuration.service.ts
+++ b/apps/api/src/services/configuration/configuration.service.ts
@@ -58,14 +58,14 @@ export class ConfigurationService {
       JWT_SECRET_KEY: str(),
       MAX_ACTIVITIES_TO_IMPORT: num({ default: Number.MAX_SAFE_INTEGER }),
       MAX_CHART_ITEMS: num({ default: 365 }),
-      OIDC_AUTHORIZATION_URL: str(),
-      OIDC_CALLBACK_URL: str(),
-      OIDC_CLIENT_ID: str(),
-      OIDC_CLIENT_SECRET: str(),
-      OIDC_ISSUER: str(),
+      OIDC_AUTHORIZATION_URL: str({ default: '' }),
+      OIDC_CALLBACK_URL: str({ default: '' }),
+      OIDC_CLIENT_ID: str({ default: '' }),
+      OIDC_CLIENT_SECRET: str({ default: '' }),
+      OIDC_ISSUER: str({ default: '' }),
       OIDC_SCOPE: json({ default: ['openid'] }),
-      OIDC_TOKEN_URL: str(),
-      OIDC_USER_INFO_URL: str(),
+      OIDC_TOKEN_URL: str({ default: '' }),
+      OIDC_USER_INFO_URL: str({ default: '' }),
       PORT: port({ default: DEFAULT_PORT }),
       PROCESSOR_GATHER_ASSET_PROFILE_CONCURRENCY: num({
         default: DEFAULT_PROCESSOR_GATHER_ASSET_PROFILE_CONCURRENCY