From 5567b786538c4f95978a7d9dfa00760c3f8a6229 Mon Sep 17 00:00:00 2001
From: arjun jaiswal <arjunjaiswal4242@gmail.com>
Date: Mon, 6 Jul 2026 16:54:29 +0530
Subject: [PATCH] Address PR review comments

---
 .../portfolio/activities/activities-page.component.ts      | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts b/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
index be45345eb..91f4b6210 100644
--- a/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
@@ -39,13 +39,13 @@ import { GfImportActivitiesDialogComponent } from './import-activities-dialog/im
 import { ImportActivitiesDialogParams } from './import-activities-dialog/interfaces/interfaces';
 
 @Component({
+  changeDetection: ChangeDetectionStrategy.OnPush,
   imports: [
     GfActivitiesTableComponent,
     GfFabComponent,
     MatSnackBarModule,
     RouterModule
   ],
-  changeDetection: ChangeDetectionStrategy.OnPush,
   selector: 'gf-activities-page',
   styleUrls: ['./activities-page.scss'],
   templateUrl: './activities-page.html'
@@ -114,6 +114,7 @@ export class GfActivitiesPageComponent implements OnInit {
       .pipe(takeUntilDestroyed(this.destroyRef))
       .subscribe((impersonationId) => {
         this.hasImpersonationId = !!impersonationId;
+
         this.changeDetectorRef.markForCheck();
       });
 
@@ -135,8 +136,6 @@ export class GfActivitiesPageComponent implements OnInit {
     this.dataSource = undefined;
     this.totalItems = undefined;
 
-    this.changeDetectorRef.markForCheck();
-
     const dateRange = this.user?.settings?.dateRange;
     const range = this.isCalendarYear(dateRange) ? dateRange : undefined;
 
@@ -453,7 +452,5 @@ export class GfActivitiesPageComponent implements OnInit {
     this.hasPermissionToDeleteActivity =
       !this.hasImpersonationId &&
       hasPermission(this.user.permissions, permissions.deleteActivity);
-
-    this.changeDetectorRef.markForCheck();
   }
 }