From 564bff2ee220034fabf58ca24dcb1f04ca1ce6db Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 7 Feb 2025 17:40:29 +0100 Subject: [PATCH] Refactoring --- .../regional-market-cluster-risk/emerging-markets.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts b/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts index f4de0f355..2d9a3b394 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts @@ -15,7 +15,7 @@ export class RegionalMarketClusterRiskEmergingMarkets extends Rule { ) { super(exchangeRateDataService, { key: RegionalMarketClusterRiskEmergingMarkets.name, - name: 'Emerging markets' + name: 'Emerging Markets' }); this.currentValueInBaseCurrency = currentValueInBaseCurrency; @@ -31,14 +31,14 @@ export class RegionalMarketClusterRiskEmergingMarkets extends Rule { if (emergingMarketsValueRatio > ruleSettings.thresholdMax) { return { - evaluation: `The Emerging markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) exceeds ${( + evaluation: `The Emerging Markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) exceeds ${( ruleSettings.thresholdMax * 100 ).toPrecision(3)}%`, value: false }; } else if (emergingMarketsValueRatio < ruleSettings.thresholdMin) { return { - evaluation: `The Emerging markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) is below ${( + evaluation: `The Emerging Markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) is below ${( ruleSettings.thresholdMin * 100 ).toPrecision(3)}%`, value: false @@ -46,7 +46,7 @@ export class RegionalMarketClusterRiskEmergingMarkets extends Rule { } return { - evaluation: `The Emerging markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) is within the range of ${( + evaluation: `The Emerging Markets contribution of your current investment (${(emergingMarketsValueRatio * 100).toPrecision(3)}%) is within the range of ${( ruleSettings.thresholdMin * 100 ).toPrecision( 3