From 5754f0181993a526a0e0f165230ef7f671e168c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20Szyma=C5=84ski?= Date: Fri, 4 Apr 2025 21:10:26 +0100 Subject: [PATCH] Feature/improve check for duplicates in preview step of activities import (comments) (#4498) * Improve check for duplicates in preview step of activities import (comments) * Update changelog --- CHANGELOG.md | 1 + apps/api/src/app/import/import.service.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ec9773a4..3313e43c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Improved the check for duplicates in the preview step of the activities import (allow different comments) - Improved the language localization for German (`fr`) - Upgraded `ng-extract-i18n-merge` from version `2.14.1` to `2.14.3` diff --git a/apps/api/src/app/import/import.service.ts b/apps/api/src/app/import/import.service.ts index 729049fd1..9a4fff5ed 100644 --- a/apps/api/src/app/import/import.service.ts +++ b/apps/api/src/app/import/import.service.ts @@ -519,6 +519,7 @@ export class ImportService { const isDuplicate = existingActivities.some((activity) => { return ( activity.accountId === accountId && + activity.comment === comment && activity.SymbolProfile.currency === currency && activity.SymbolProfile.dataSource === dataSource && isSameSecond(activity.date, date) &&