Browse Source
Task/set change detection strategy to OnPush in portfolio holdings page (#7264)
* Set change detection strategy to OnPush
* Update changelog
pull/7259/head
KBS
7 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
7 additions and
2 deletions
-
CHANGELOG.md
-
apps/client/src/app/components/home-holdings/home-holdings.component.ts
|
|
|
@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
### Changed |
|
|
|
|
|
|
|
- Improved the user account deletion flow in the user settings of the user account page |
|
|
|
- Set the change detection strategy to `OnPush` in the portfolio holdings page |
|
|
|
- Set the change detection strategy to `OnPush` in the _FIRE_ page |
|
|
|
- Set the change detection strategy to `OnPush` in the users section of the admin control panel |
|
|
|
- Improved the language localization for Dutch (`nl`) |
|
|
|
|
|
|
|
@ -15,6 +15,7 @@ import { GfToggleComponent } from '@ghostfolio/ui/toggle'; |
|
|
|
import { GfTreemapChartComponent } from '@ghostfolio/ui/treemap-chart'; |
|
|
|
|
|
|
|
import { |
|
|
|
ChangeDetectionStrategy, |
|
|
|
ChangeDetectorRef, |
|
|
|
Component, |
|
|
|
CUSTOM_ELEMENTS_SCHEMA, |
|
|
|
@ -32,6 +33,7 @@ import { gridOutline, reorderFourOutline } from 'ionicons/icons'; |
|
|
|
import { DeviceDetectorService } from 'ngx-device-detector'; |
|
|
|
|
|
|
|
@Component({ |
|
|
|
changeDetection: ChangeDetectionStrategy.OnPush, |
|
|
|
imports: [ |
|
|
|
FormsModule, |
|
|
|
GfHoldingsTableComponent, |
|
|
|
@ -88,6 +90,8 @@ export class GfHomeHoldingsComponent implements OnInit { |
|
|
|
.pipe(takeUntilDestroyed(this.destroyRef)) |
|
|
|
.subscribe((impersonationId) => { |
|
|
|
this.hasImpersonationId = !!impersonationId; |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
}); |
|
|
|
|
|
|
|
this.userService.stateChanged |
|
|
|
@ -107,9 +111,9 @@ export class GfHomeHoldingsComponent implements OnInit { |
|
|
|
); |
|
|
|
|
|
|
|
this.initialize(); |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
} |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
}); |
|
|
|
|
|
|
|
this.viewModeFormControl.valueChanges |
|
|
|
|