Merge 7c96ae3d9a into 0d58df7ce7

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Changed
+
+- Improved the performance of the market data range query for portfolios with many holdings
+
 ## 3.90.0 - 2026-10-21
 
 ### Changed

apps/api/src/services/market-data/market-data.service.spec.ts

@@ -9,6 +9,7 @@ describe('MarketDataService', () => {
     marketData: {
       createMany: jest.Mock;
       deleteMany: jest.Mock;
+      findMany: jest.Mock;
       upsert: jest.Mock;
     };
   };
@@ -19,6 +20,7 @@ describe('MarketDataService', () => {
       marketData: {
         createMany: jest.fn(),
         deleteMany: jest.fn(),
+        findMany: jest.fn().mockResolvedValue([]),
         upsert: jest.fn().mockResolvedValue({})
       }
     };
@@ -26,6 +28,26 @@ describe('MarketDataService', () => {
     marketDataService = new MarketDataService(prismaService as any);
   });
 
+  describe('getRange', () => {
+    it('queries the symbols grouped by data source', async () => {
+      await marketDataService.getRange({
+        assetProfileIdentifiers: [
+          { dataSource: 'YAHOO', symbol: 'AAPL' },
+          { dataSource: 'COINGECKO', symbol: 'bitcoin' },
+          { dataSource: 'YAHOO', symbol: 'MSFT' }
+        ],
+        dateQuery: { gte: parseDate('2026-01-01') }
+      });
+
+      expect(
+        prismaService.marketData.findMany.mock.calls[0][0].where.OR
+      ).toEqual([
+        { dataSource: 'YAHOO', symbol: { in: ['AAPL', 'MSFT'] } },
+        { dataSource: 'COINGECKO', symbol: { in: ['bitcoin'] } }
+      ]);
+    });
+  });
+
   describe('updateMany', () => {
     it('does not drop isCarriedForward', async () => {
       prismaService.$transaction.mockImplementation((promises) => {

apps/api/src/services/market-data/market-data.service.ts

@@ -12,6 +12,7 @@ import {
   MarketDataState,
   Prisma
 } from '@prisma/client';
+import { groupBy } from 'lodash-es';
 
 @Injectable()
 export class MarketDataService {
@@ -95,12 +96,7 @@ export class MarketDataService {
       ],
       where: {
         date: dateQuery,
-        OR: assetProfileIdentifiers.map(({ dataSource, symbol }) => {
+        OR: this.getAssetProfileIdentifiersCondition(assetProfileIdentifiers)
-          return {
-            dataSource,
-            symbol
-          };
-        })
       }
     });
   }
@@ -115,12 +111,7 @@ export class MarketDataService {
     return this.prismaService.marketData.count({
       where: {
         date: dateQuery,
-        OR: assetProfileIdentifiers.map(({ dataSource, symbol }) => {
+        OR: this.getAssetProfileIdentifiersCondition(assetProfileIdentifiers)
-          return {
-            dataSource,
-            symbol
-          };
-        })
       }
     });
   }
@@ -260,4 +251,25 @@ export class MarketDataService {
 
     return this.prismaService.$transaction(upsertPromises);
   }
+
+  // One condition per data source with all its symbols, since a condition per
+  // asset profile identifier is slow to evaluate for many asset profiles
+  private getAssetProfileIdentifiersCondition(
+    aAssetProfileIdentifiers: AssetProfileIdentifier[]
+  ): Prisma.MarketDataWhereInput[] {
+    return Object.entries(
+      groupBy(aAssetProfileIdentifiers, ({ dataSource }) => {
+        return dataSource;
+      })
+    ).map(([dataSource, assetProfileIdentifiers]) => {
+      return {
+        dataSource: dataSource as DataSource,
+        symbol: {
+          in: assetProfileIdentifiers.map(({ symbol }) => {
+            return symbol;
+          })
+        }
+      };
+    });
+  }
 }