From 5a3a4ab9eceb66f2d63628ac392a4334cd8b5b51 Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 3 Dec 2022 17:24:35 +0100
Subject: [PATCH] Refactoring

---
 apps/api/src/services/exchange-rate-data.service.ts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/apps/api/src/services/exchange-rate-data.service.ts b/apps/api/src/services/exchange-rate-data.service.ts
index e68b4ef52..cbaa38af0 100644
--- a/apps/api/src/services/exchange-rate-data.service.ts
+++ b/apps/api/src/services/exchange-rate-data.service.ts
@@ -171,16 +171,20 @@ export class ExchangeRateDataService {
     let factor = 1;
 
     if (aFromCurrency !== aToCurrency) {
+      const dataSource = this.dataProviderService.getPrimaryDataSource();
+      const symbol = `${aFromCurrency}${aToCurrency}`;
+
       const marketData = await this.marketDataService.get({
-        dataSource: this.dataProviderService.getPrimaryDataSource(),
-        date: aDate,
-        symbol: `${aFromCurrency}${aToCurrency}`
+        dataSource,
+        symbol,
+        date: aDate
       });
 
       if (marketData?.marketPrice) {
         factor = marketData?.marketPrice;
       } else {
-        // TODO: Calculate indirectly via base currency
+        // TODO: Get from data provider service or calculate indirectly via base currency
+        // and market data
         return this.toCurrency(aValue, aFromCurrency, aToCurrency);
       }
     }