From 5b5b662758b3b322c6b3dedae79cc25d763410ee Mon Sep 17 00:00:00 2001
From: Dan <dan@ddev.ch>
Date: Thu, 20 Feb 2025 19:56:15 +0100
Subject: [PATCH] Add colorSIgn & fix calculation

---
 libs/ui/src/lib/holdings-table/holdings-table.component.html | 2 ++
 libs/ui/src/lib/holdings-table/holdings-table.component.ts   | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.html b/libs/ui/src/lib/holdings-table/holdings-table.component.html
index 48a652ebe..5067555a1 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.html
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.html
@@ -145,6 +145,7 @@
       <td *matFooterCellDef class="px-1" mat-footer-cell>
         <div class="d-flex justify-content-end">
           <gf-value
+            [colorizeSign]="true"
             [isCurrency]="true"
             [locale]="locale"
             [value]="totalChange"
@@ -180,6 +181,7 @@
       <td *matFooterCellDef class="px-1" mat-footer-cell>
         <div class="d-flex justify-content-end">
           <gf-value
+            [colorizeSign]="true"
             [isPercent]="true"
             [locale]="locale"
             [value]="totalChangePercentage"
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index c40b69a12..57040a96b 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -97,11 +97,11 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
     this.dataSource.paginator = this.paginator;
     this.dataSource.sort = this.sort;
     this.totalValue = this.dataSource.data.reduce(
-      (sum, current) => sum + current.valueInBaseCurrency,
+      (sum, current) => (sum += current.valueInBaseCurrency),
       0
     );
     this.totalChange = this.dataSource.data.reduce(
-      (sum, current) => sum + current.netPerformancePercentWithCurrencyEffect,
+      (sum, current) => (sum += current.netPerformanceWithCurrencyEffect),
       0
     );
     this.totalChangePercentage = (this.totalChange / this.totalValue) * 100;