Refactoring

apps/api/src/app/endpoints/asset-profiles/asset-profiles.service.ts

@@ -199,7 +199,6 @@ export class AssetProfilesService {
         const {
           _count,
           activities,
-          comment,
           currency,
           dataSource,
           id,
@@ -234,7 +233,6 @@ export class AssetProfilesService {
         return {
           assetClass,
           assetSubClass,
-          comment,
           countriesCount,
           currency,
           dataSource,
@@ -414,21 +412,20 @@ export class AssetProfilesService {
 
         return {
           activitiesCount,
+          currency,
+          dataSource,
+          lastMarketPrice,
+          marketDataItemCount,
+          symbol,
           assetClass: AssetClass.LIQUIDITY,
           assetSubClass: AssetSubClass.CASH,
-          comment: null,
           countriesCount: 0,
-          currency,
-          dataSource,
           date: dateOfFirstActivity,
           id: undefined,
           isActive: true,
           isin: null,
-          lastMarketPrice,
-          marketDataItemCount,
           name: symbol,
           sectorsCount: 0,
-          symbol,
           watchedByCount: 0
         };
       }

libs/common/src/lib/interfaces/responses/asset-profile-item.interface.ts → libs/common/src/lib/interfaces/asset-profile-item.interface.ts

@@ -4,7 +4,6 @@ export interface AssetProfileItem {
   activitiesCount: number;
   assetClass?: AssetClass;
   assetSubClass?: AssetSubClass;
-  comment?: string | null;
   countriesCount: number;
   currency: string;
   dataSource: DataSource;
@@ -21,8 +20,3 @@ export interface AssetProfileItem {
   symbol: string;
   watchedByCount: number;
 }
-
-export interface AssetProfilesResponse {
-  assetProfiles: AssetProfileItem[];
-  count: number;
-}

libs/common/src/lib/interfaces/index.ts

@@ -7,6 +7,7 @@ import type { AdminMarketDataDetails } from './admin-market-data-details.interfa
 import type { AdminUser } from './admin-user.interface';
 import type { AssetClassSelectorOption } from './asset-class-selector-option.interface';
 import type { AssetProfileIdentifier } from './asset-profile-identifier.interface';
+import type { AssetProfileItem } from './asset-profile-item.interface';
 import type { BenchmarkProperty } from './benchmark-property.interface';
 import type { Benchmark } from './benchmark.interface';
 import type { Coupon } from './coupon.interface';
@@ -42,10 +43,7 @@ import type { AdminUsersResponse } from './responses/admin-users-response.interf
 import type { AiPromptResponse } from './responses/ai-prompt-response.interface';
 import type { AiServiceHealthResponse } from './responses/ai-service-health-response.interface';
 import type { ApiKeyResponse } from './responses/api-key-response.interface';
-import type {
-  AssetProfileItem,
-  AssetProfilesResponse
-} from './responses/asset-profile-item.interface';
+import type { AssetProfilesResponse } from './responses/asset-profiles-response.interface';
 import type { AssetResponse } from './responses/asset-response.interface';
 import type { BenchmarkMarketDataDetailsResponse } from './responses/benchmark-market-data-details-response.interface';
 import type { BenchmarkResponse } from './responses/benchmark-response.interface';

libs/common/src/lib/interfaces/responses/asset-profiles-response.interface.ts

@@ -0,0 +1,6 @@
+import { AssetProfileItem } from '../asset-profile-item.interface';
+
+export interface AssetProfilesResponse {
+  assetProfiles: AssetProfileItem[];
+  count: number;
+}