Merge 0c0b3e6023 into c9cc020540

libs/ui/src/lib/holdings-table/holdings-table.component.html

@@ -80,9 +80,9 @@
       >
         <div class="d-flex justify-content-end">
           <gf-value
-            [isCurrency]="true"
             [isLoading]="isLoading()"
             [locale]="locale()"
+            [precision]="getQuantityPrecision(element)"
             [value]="element.quantity"
           />
         </div>

libs/ui/src/lib/holdings-table/holdings-table.component.ts

@@ -28,6 +28,7 @@ import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
 import { GfEntityLogoComponent } from '../entity-logo/entity-logo.component';
 import { GfValueComponent } from '../value/value.component';
+import { getHoldingQuantityPrecision } from './quantity-precision';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -103,6 +104,10 @@ export class GfHoldingsTableComponent {
     return this.hasPermissionToOpenDetails() && canOpenHoldingDetail(holding);
   }
 
+  protected getQuantityPrecision(holding: PortfolioPosition): number {
+    return getHoldingQuantityPrecision(holding);
+  }
+
   protected onOpenHoldingDialog({
     dataSource,
     symbol

libs/ui/src/lib/holdings-table/quantity-precision.spec.ts

@@ -0,0 +1,44 @@
+import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+
+import { AssetSubClass } from '@prisma/client';
+
+import { getHoldingQuantityPrecision } from './quantity-precision';
+
+function createHolding(
+  quantity: number,
+  assetSubClass: AssetSubClass
+): Pick<PortfolioPosition, 'assetProfile' | 'quantity'> {
+  return {
+    assetProfile: { assetSubClass } as PortfolioPosition['assetProfile'],
+    quantity
+  };
+}
+
+describe('getHoldingQuantityPrecision', () => {
+  it('preserves satoshi precision for fractional cryptocurrency quantities', () => {
+    expect(
+      getHoldingQuantityPrecision(
+        createHolding(0.01525217, AssetSubClass.CRYPTOCURRENCY)
+      )
+    ).toBe(8);
+    expect(
+      getHoldingQuantityPrecision(
+        createHolding(10.12345678, AssetSubClass.CRYPTOCURRENCY)
+      )
+    ).toBe(8);
+  });
+
+  it('does not add decimal places to integer cryptocurrency quantities', () => {
+    expect(
+      getHoldingQuantityPrecision(
+        createHolding(12, AssetSubClass.CRYPTOCURRENCY)
+      )
+    ).toBe(0);
+  });
+
+  it('keeps the existing precision for non-cryptocurrency quantities', () => {
+    expect(
+      getHoldingQuantityPrecision(createHolding(12.3456, AssetSubClass.STOCK))
+    ).toBe(2);
+  });
+});

libs/ui/src/lib/holdings-table/quantity-precision.ts

@@ -0,0 +1,17 @@
+import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+
+import { AssetSubClass } from '@prisma/client';
+
+export function getHoldingQuantityPrecision(
+  holding: Pick<PortfolioPosition, 'assetProfile' | 'quantity'>
+): number {
+  if (Number.isInteger(holding.quantity)) {
+    return 0;
+  }
+
+  if (holding.assetProfile.assetSubClass === AssetSubClass.CRYPTOCURRENCY) {
+    return 8;
+  }
+
+  return 2;
+}