From 5f7e1976f6f4362afa69593afce70871086bb5d6 Mon Sep 17 00:00:00 2001
From: Mirio <miriodev@gmail.com>
Date: Tue, 21 Feb 2023 18:22:46 +0100
Subject: [PATCH] Submit the changes requested on the pull requests #1736
 revision 2

---
 .../data-provider/coingecko/coingecko.service.ts  | 15 +++------------
 .../data-provider/data-provider.module.ts         |  4 ++--
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts b/apps/api/src/services/data-provider/coingecko/coingecko.service.ts
index f0a061f50..43830023a 100644
--- a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts
+++ b/apps/api/src/services/data-provider/coingecko/coingecko.service.ts
@@ -20,7 +20,6 @@ import { format, differenceInDays, addDays, subDays } from 'date-fns';
 @Injectable()
 export class CoinGeckoService implements DataProviderInterface {
   private readonly URL = 'https://api.coingecko.com/api/v3';
-  private COINLIST = [];
   private baseCurrency: string;
   private DB = {};
 
@@ -51,15 +50,6 @@ export class CoinGeckoService implements DataProviderInterface {
     return {};
   }
 
-  private async getCoinList() {
-    // TODO: Some caching refresh after X?
-    if (this.COINLIST.length == 0) {
-      const req = bent(`${this.URL}/coins/list`, 'GET', 'json', 200);
-      const response = await req();
-      this.COINLIST = response;
-    }
-  }
-
   public async getAssetProfile(
     aSymbol: string
   ): Promise<Partial<SymbolProfile>> {
@@ -177,11 +167,12 @@ export class CoinGeckoService implements DataProviderInterface {
 
   public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
     const items: LookupItem[] = [];
-    await this.getCoinList();
     if (aQuery.length <= 2) {
       return { items };
     }
-    for (const coiniter of this.COINLIST) {
+    const req = bent(`${this.URL}/search?query=${aQuery}`, 'GET', 'json', 200);
+    const response = await req();
+    for (const coiniter of response.coins) {
       if (coiniter.id.toLowerCase().includes(aQuery)) {
         items.push({
           symbol: coiniter.id.toUpperCase(),
diff --git a/apps/api/src/services/data-provider/data-provider.module.ts b/apps/api/src/services/data-provider/data-provider.module.ts
index fc49de400..d36a12aa6 100644
--- a/apps/api/src/services/data-provider/data-provider.module.ts
+++ b/apps/api/src/services/data-provider/data-provider.module.ts
@@ -42,7 +42,7 @@ import { DataProviderService } from './data-provider.service';
       provide: 'DataProviderInterfaces',
       useFactory: (
         alphaVantageService,
-        CoinGeckoService,
+        coinGeckoService,
         eodHistoricalDataService,
         googleSheetsService,
         manualService,
@@ -50,7 +50,7 @@ import { DataProviderService } from './data-provider.service';
         yahooFinanceService
       ) => [
         alphaVantageService,
-        CoinGeckoService,
+        coinGeckoService,
         eodHistoricalDataService,
         googleSheetsService,
         manualService,