From 53a09b4e228426ef1cfaea92adfb371ae458ca13 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 4 Jan 2026 09:17:43 +0100 Subject: [PATCH 1/2] Remove deprecated activities --- .../src/app/portfolio/portfolio.service.ts | 1 - .../portfolio-holding-response.interface.ts | 4 ---- libs/ui/src/lib/services/data.service.ts | 19 +++---------------- 3 files changed, 3 insertions(+), 21 deletions(-) diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 5613af9e7..85dc063b5 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -920,7 +920,6 @@ export class PortfolioService { marketPriceMin, SymbolProfile, tags, - activities: activitiesOfHolding, activitiesCount: transactionCount, averagePrice: averagePrice.toNumber(), dataProviderInfo: portfolioCalculator.getDataProviderInfos()?.[0], diff --git a/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts b/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts index 4ec42933a..95c1c3689 100644 --- a/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts +++ b/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts @@ -1,5 +1,4 @@ import { - Activity, Benchmark, DataProviderInfo, EnhancedSymbolProfile, @@ -9,9 +8,6 @@ import { import { Tag } from '@prisma/client'; export interface PortfolioHoldingResponse { - /** @deprecated */ - activities: Activity[]; - activitiesCount: number; averagePrice: number; dataProviderInfo: DataProviderInfo; diff --git a/libs/ui/src/lib/services/data.service.ts b/libs/ui/src/lib/services/data.service.ts index 21eec06c3..37443cd20 100644 --- a/libs/ui/src/lib/services/data.service.ts +++ b/libs/ui/src/lib/services/data.service.ts @@ -424,22 +424,9 @@ export class DataService { dataSource: DataSource; symbol: string; }) { - return this.http - .get( - `/api/v1/portfolio/holding/${dataSource}/${symbol}` - ) - .pipe( - map((data) => { - if (data.activities) { - for (const order of data.activities) { - order.createdAt = parseISO(order.createdAt as unknown as string); - order.date = parseISO(order.date as unknown as string); - } - } - - return data; - }) - ); + return this.http.get( + `/api/v1/portfolio/holding/${dataSource}/${symbol}` + ); } public fetchInfo(): InfoItem { From 545ed4e0571dc4ff4e7aba050a18e25fb5e39e4f Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 4 Jan 2026 09:19:11 +0100 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf81cb29e..3ff7c031a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Deprecated `activities` in the endpoint `GET api/v1/portfolio/holding/:dataSource/:symbol` +- Removed the deprecated `activities` from the endpoint `GET api/v1/portfolio/holding/:dataSource/:symbol` - Moved the data service to `@ghostfolio/ui/services` - Refactored the dividend import