Browse Source
			
			
			Bugfix/fix value in holdings table (#2182)
			
				* Fix missing value
* Update changelog
			
			
				pull/2179/head^2
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					2 years ago
						Thomas Kaul
					
					2 years ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 3 changed files with 
9 additions and 
3 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					libs/ui/src/lib/holdings-table/holdings-table.component.html
				
- 
					
					
					 
					libs/ui/src/lib/holdings-table/holdings-table.component.ts
				
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. | 
			
		
	
		
		
			
				
					|  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), |  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | 
			
		
	
		
		
			
				
					|  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). |  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | ## Unreleased | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | ### Fixed | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | - Fixed the missing values in the holdings table | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  | ## 1.292.0 - 2023-07-24 |  |  | ## 1.292.0 - 2023-07-24 | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  | ### Added |  |  | ### Added | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -61,7 +61,7 @@ | 
			
		
	
		
		
			
				
					|  |  |       </td> |  |  |       </td> | 
			
		
	
		
		
			
				
					|  |  |     </ng-container> |  |  |     </ng-container> | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					
					|  |  |     <ng-container matColumnDef="value"> |  |  |     <ng-container matColumnDef="valueInBaseCurrency"> | 
			
				
				
			
		
	
		
		
	
		
		
			
				
					|  |  |       <th |  |  |       <th | 
			
		
	
		
		
			
				
					|  |  |         *matHeaderCellDef |  |  |         *matHeaderCellDef | 
			
		
	
		
		
			
				
					|  |  |         class="d-none d-lg-table-cell justify-content-end px-1" |  |  |         class="d-none d-lg-table-cell justify-content-end px-1" | 
			
		
	
	
		
		
			
				
					|  | @ -79,7 +79,7 @@ | 
			
		
	
		
		
			
				
					|  |  |           <gf-value |  |  |           <gf-value | 
			
		
	
		
		
			
				
					|  |  |             [isCurrency]="true" |  |  |             [isCurrency]="true" | 
			
		
	
		
		
			
				
					|  |  |             [locale]="locale" |  |  |             [locale]="locale" | 
			
		
	
		
		
			
				
					
					|  |  |             [value]="isLoading ? undefined : element.value" |  |  |             [value]="isLoading ? undefined : element.valueInBaseCurrency" | 
			
				
				
			
		
	
		
		
	
		
		
			
				
					|  |  |           ></gf-value> |  |  |           ></gf-value> | 
			
		
	
		
		
			
				
					|  |  |         </div> |  |  |         </div> | 
			
		
	
		
		
			
				
					|  |  |       </td> |  |  |       </td> | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -55,7 +55,7 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit { | 
			
		
	
		
		
			
				
					|  |  |     this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity']; |  |  |     this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity']; | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |     if (this.hasPermissionToShowValues) { |  |  |     if (this.hasPermissionToShowValues) { | 
			
		
	
		
		
			
				
					
					|  |  |       this.displayedColumns.push('value'); |  |  |       this.displayedColumns.push('valueInBaseCurrency'); | 
			
				
				
			
		
	
		
		
	
		
		
			
				
					|  |  |     } |  |  |     } | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |     this.displayedColumns.push('allocationInPercentage'); |  |  |     this.displayedColumns.push('allocationInPercentage'); | 
			
		
	
	
		
		
			
				
					|  | 
 |