Feature/refactor portfolio calculator factory (#4454)

* Refactor portfolio calculator factory

apps/api/src/app/portfolio/calculator/mwr/portfolio-calculator.ts

@@ -5,7 +5,7 @@ import {
 } from '@ghostfolio/common/interfaces';
 import { PortfolioSnapshot } from '@ghostfolio/common/models';
 
-export class MWRPortfolioCalculator extends PortfolioCalculator {
+export class MwrPortfolioCalculator extends PortfolioCalculator {
   protected calculateOverallPerformance(): PortfolioSnapshot {
     throw new Error('Method not implemented.');
   }

apps/api/src/app/portfolio/calculator/portfolio-calculator.factory.ts

@@ -8,13 +8,15 @@ import { Filter, HistoricalDataItem } from '@ghostfolio/common/interfaces';
 
 import { Injectable } from '@nestjs/common';
 
-import { MWRPortfolioCalculator } from './mwr/portfolio-calculator';
+import { MwrPortfolioCalculator } from './mwr/portfolio-calculator';
 import { PortfolioCalculator } from './portfolio-calculator';
 import { RoaiPortfolioCalculator } from './roai/portfolio-calculator';
+import { TwrPortfolioCalculator } from './twr/portfolio-calculator';
 
 export enum PerformanceCalculationType {
   MWR = 'MWR', // Money-Weighted Rate of Return
-  ROAI = 'ROAI' // Return on Average Investment
+  ROAI = 'ROAI', // Return on Average Investment
+  TWR = 'TWR' // Time-Weighted Rate of Return
 }
 
 @Injectable()
@@ -44,7 +46,7 @@ export class PortfolioCalculatorFactory {
   }): PortfolioCalculator {
     switch (calculationType) {
       case PerformanceCalculationType.MWR:
-        return new MWRPortfolioCalculator({
+        return new MwrPortfolioCalculator({
           accountBalanceItems,
           activities,
           currency,
@@ -61,10 +63,23 @@ export class PortfolioCalculatorFactory {
           accountBalanceItems,
           activities,
           currency,
+          filters,
+          userId,
+          configurationService: this.configurationService,
           currentRateService: this.currentRateService,
+          exchangeRateDataService: this.exchangeRateDataService,
+          portfolioSnapshotService: this.portfolioSnapshotService,
+          redisCacheService: this.redisCacheService
+        });
+      case PerformanceCalculationType.TWR:
+        return new TwrPortfolioCalculator({
+          accountBalanceItems,
+          activities,
+          currency,
           filters,
           userId,
           configurationService: this.configurationService,
+          currentRateService: this.currentRateService,
           exchangeRateDataService: this.exchangeRateDataService,
           portfolioSnapshotService: this.portfolioSnapshotService,
           redisCacheService: this.redisCacheService

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts

@@ -0,0 +1,24 @@
+import { PortfolioCalculator } from '@ghostfolio/api/app/portfolio/calculator/portfolio-calculator';
+import {
+  AssetProfileIdentifier,
+  SymbolMetrics
+} from '@ghostfolio/common/interfaces';
+import { PortfolioSnapshot } from '@ghostfolio/common/models';
+
+export class TwrPortfolioCalculator extends PortfolioCalculator {
+  protected calculateOverallPerformance(): PortfolioSnapshot {
+    throw new Error('Method not implemented.');
+  }
+
+  protected getSymbolMetrics({}: {
+    end: Date;
+    exchangeRates: { [dateString: string]: number };
+    marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    };
+    start: Date;
+    step?: number;
+  } & AssetProfileIdentifier): SymbolMetrics {
+    throw new Error('Method not implemented.');
+  }
+}