Browse Source

Merge branch 'main' into feature/extend-account-detail-dialog-by-performance

pull/8259/head
Thomas Kaul 1 day ago
committed by GitHub
parent
commit
613cfa6901
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 2
      CHANGELOG.md
  2. 7
      apps/api/src/app/endpoints/asset-profiles/asset.controller.ts
  3. 368
      apps/client/src/locales/messages.ca.xlf
  4. 368
      apps/client/src/locales/messages.de.xlf
  5. 368
      apps/client/src/locales/messages.es.xlf
  6. 368
      apps/client/src/locales/messages.fr.xlf
  7. 368
      apps/client/src/locales/messages.it.xlf
  8. 368
      apps/client/src/locales/messages.ja.xlf
  9. 368
      apps/client/src/locales/messages.ko.xlf
  10. 368
      apps/client/src/locales/messages.nl.xlf
  11. 368
      apps/client/src/locales/messages.pl.xlf
  12. 368
      apps/client/src/locales/messages.pt.xlf
  13. 368
      apps/client/src/locales/messages.tr.xlf
  14. 368
      apps/client/src/locales/messages.uk.xlf
  15. 361
      apps/client/src/locales/messages.xlf
  16. 368
      apps/client/src/locales/messages.zh.xlf
  17. 9
      libs/ui/src/lib/benchmark/benchmark-detail-dialog/benchmark-detail-dialog.component.ts
  18. 5
      libs/ui/src/lib/benchmark/benchmark-detail-dialog/benchmark-detail-dialog.html
  19. 8
      package-lock.json
  20. 2
      package.json

2
CHANGELOG.md

@ -14,8 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Extended the account detail dialog to include the change and the performance
- Improved the market price in the benchmark detail dialog by adding the currency and reducing the precision on mobile
- Improved the style of the close button in the dialog footer component
- Improved the style of the close button in the dialog header component
- Upgraded `prettier` from version `3.9.9` to `3.9.10`
## 3.90.0 - 2026-10-21

7
apps/api/src/app/endpoints/asset-profiles/asset.controller.ts

@ -30,7 +30,12 @@ export class AssetController {
return {
marketData,
splits,
assetProfile: pick(assetProfile, ['dataSource', 'name', 'symbol'])
assetProfile: {
...pick(assetProfile, ['dataSource', 'name', 'symbol']),
// An index has no asset class and its value has no currency,
// thus show no currency for any asset profile without asset class
currency: assetProfile.assetClass ? assetProfile.currency : undefined
}
};
}
}

368
apps/client/src/locales/messages.ca.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.de.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.es.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.fr.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.it.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.ja.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.ko.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.nl.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.pl.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.pt.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.tr.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.uk.xlf

File diff suppressed because it is too large

361
apps/client/src/locales/messages.xlf

File diff suppressed because it is too large

368
apps/client/src/locales/messages.zh.xlf

File diff suppressed because it is too large

9
libs/ui/src/lib/benchmark/benchmark-detail-dialog/benchmark-detail-dialog.component.ts

@ -1,3 +1,4 @@
import { NUMERICAL_PRECISION_THRESHOLD_4_FIGURES } from '@ghostfolio/common/config';
import { DATE_FORMAT } from '@ghostfolio/common/helper';
import {
AdminMarketDataDetails,
@ -47,6 +48,7 @@ export class GfBenchmarkDetailDialogComponent implements OnInit {
public assetProfile?: AdminMarketDataDetails['assetProfile'];
public historicalDataItems: LineChartItem[];
public isLoading = true;
public precision = 2;
public value: number;
public constructor(
@ -80,6 +82,13 @@ export class GfBenchmarkDetailDialogComponent implements OnInit {
}
);
if (
this.data.deviceType === 'mobile' &&
this.value >= NUMERICAL_PRECISION_THRESHOLD_4_FIGURES
) {
this.precision = 0;
}
this.isLoading = false;
this.changeDetectorRef.markForCheck();

5
libs/ui/src/lib/benchmark/benchmark-detail-dialog/benchmark-detail-dialog.html

@ -13,16 +13,17 @@
size="large"
[isLoading]="isLoading"
[locale]="data.locale"
[precision]="2"
[precision]="precision"
[unit]="assetProfile?.currency"
[value]="value"
/>
</div>
</div>
<gf-line-chart
benchmarkLabel="Average Unit Price"
class="mb-4"
[colorScheme]="data.colorScheme"
[currency]="assetProfile?.currency"
[historicalDataItems]="historicalDataItems"
[isAnimated]="true"
[label]="data.symbol"

8
package-lock.json

@ -163,7 +163,7 @@
"jest-environment-node": "30.3.0",
"jest-preset-angular": "17.0.0",
"nx": "23.2.1",
"prettier": "3.9.9",
"prettier": "3.9.10",
"prettier-plugin-organize-attributes": "1.0.0",
"prisma": "7.10.0",
"react": "18.2.0",
@ -29600,9 +29600,9 @@
}
},
"node_modules/prettier": {
"version": "3.9.9",
"resolved": "https://registry.npmjs.org/prettier/-/prettier-3.9.9.tgz",
"integrity": "sha512-Z/CJHIkdujO/OtN7nXUii0Rf3VT5SRuhjBA82Xvu2XhBUgX3nhP67T0LHceBdQLex7OOFGTox+Q5Yg8Jk2Qivg==",
"version": "3.9.10",
"resolved": "https://registry.npmjs.org/prettier/-/prettier-3.9.10.tgz",
"integrity": "sha512-skGHTH1Yb9QvaTC4hWnRTzEYtCpApF0UMBPz+t/0ZPzP8ihefo/btKd+QA7pUE0fEwA1SbS/NmhyEcstdXOIdA==",
"dev": true,
"license": "MIT",
"bin": {

2
package.json

@ -207,7 +207,7 @@
"jest-environment-node": "30.3.0",
"jest-preset-angular": "17.0.0",
"nx": "23.2.1",
"prettier": "3.9.9",
"prettier": "3.9.10",
"prettier-plugin-organize-attributes": "1.0.0",
"prisma": "7.10.0",
"react": "18.2.0",

Loading…
Cancel
Save