From 6260405ab0e44937312ebe5df90cf5ce7b722c62 Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Sat, 10 Oct 2026 15:13:38 +0700
Subject: [PATCH] resolve comments

---
 .../app/components/home-holdings/home-holdings.component.ts  | 5 ++---
 .../src/app/components/home-overview/home-overview.html      | 2 +-
 libs/ui/src/lib/line-chart/line-chart.component.ts           | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/apps/client/src/app/components/home-holdings/home-holdings.component.ts b/apps/client/src/app/components/home-holdings/home-holdings.component.ts
index fdce3fcbd0..333a24d5d6 100644
--- a/apps/client/src/app/components/home-holdings/home-holdings.component.ts
+++ b/apps/client/src/app/components/home-holdings/home-holdings.component.ts
@@ -12,8 +12,7 @@ import {
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
 import { hasScope, scopes } from '@ghostfolio/common/scopes';
-import type {
-  DateRange,
+import {
   HoldingType,
   HoldingsViewMode,
   ToggleOption
@@ -66,7 +65,7 @@ export class GfHomeHoldingsComponent implements OnInit {
     return this.user()?.settings?.colorScheme;
   });
 
-  protected readonly dateRange = computed<DateRange>(() => {
+  protected readonly dateRange = computed(() => {
     return this.user()?.settings?.dateRange ?? DEFAULT_DATE_RANGE;
   });
 
diff --git a/apps/client/src/app/components/home-overview/home-overview.html b/apps/client/src/app/components/home-overview/home-overview.html
index 2f784b5428..6a166f93fd 100644
--- a/apps/client/src/app/components/home-overview/home-overview.html
+++ b/apps/client/src/app/components/home-overview/home-overview.html
@@ -73,7 +73,7 @@
             [class.pr-3]="deviceType() === 'mobile'"
             [colorScheme]="user()?.settings?.colorScheme"
             [hidden]="historicalDataItems()?.length === 0"
-            [historicalDataItems]="historicalDataItems() ?? []"
+            [historicalDataItems]="historicalDataItems()"
             [isAnimated]="user()?.settings?.dateRange === '1d' ? false : true"
             [label]="performanceLabel"
             [locale]="locale()"
diff --git a/libs/ui/src/lib/line-chart/line-chart.component.ts b/libs/ui/src/lib/line-chart/line-chart.component.ts
index e6f1b9b2e2..d910033bc0 100644
--- a/libs/ui/src/lib/line-chart/line-chart.component.ts
+++ b/libs/ui/src/lib/line-chart/line-chart.component.ts
@@ -60,7 +60,7 @@ export class GfLineChartComponent
   @Input() benchmarkLabel = '';
   @Input() colorScheme?: ColorScheme;
   @Input() currency?: string;
-  @Input() historicalDataItems: LineChartItem[];
+  @Input() historicalDataItems: LineChartItem[] | null;
   @Input() isAnimated = false;
   @Input() label: string;
   @Input() locale = getLocale();