Browse Source
Bugfix/platform icon in preview of activities import (#8148)
* Fix missing platform icon in preview of activities import
* Update changelog
pull/8157/head^2
Thomas Kaul
2 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with
12 additions and
7 deletions
-
CHANGELOG.md
-
apps/api/src/app/import/import.service.spec.ts
-
apps/api/src/app/import/import.service.ts
|
|
|
@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed the missing platform icon in the preview step of the activities import |
|
|
|
- Fixed the link of the _Manage Asset Profile_ button in the holding detail dialog before the holding has loaded |
|
|
|
|
|
|
|
## 3.85.0 - 2026-10-12 |
|
|
|
|
|
|
|
@ -69,7 +69,7 @@ describe('ImportService', () => { |
|
|
|
|
|
|
|
importService = new ImportService( |
|
|
|
{ |
|
|
|
getAccounts: jest.fn().mockResolvedValue([]) |
|
|
|
accounts: jest.fn().mockResolvedValue([]) |
|
|
|
} as unknown as AccountService, |
|
|
|
{ |
|
|
|
createActivity, |
|
|
|
|
|
|
|
@ -38,6 +38,7 @@ import { |
|
|
|
} from '@ghostfolio/common/interfaces'; |
|
|
|
import { hasPermission, permissions } from '@ghostfolio/common/permissions'; |
|
|
|
import { |
|
|
|
AccountWithPlatform, |
|
|
|
AccountWithValue, |
|
|
|
OrderWithAccount, |
|
|
|
UserWithSettings |
|
|
|
@ -769,11 +770,14 @@ export class ImportService { |
|
|
|
userId: user.id |
|
|
|
}); |
|
|
|
|
|
|
|
const accounts = (await this.accountService.getAccounts(user.id)).map( |
|
|
|
({ id, name }) => { |
|
|
|
return { id, name }; |
|
|
|
} |
|
|
|
); |
|
|
|
const accounts: Pick<AccountWithPlatform, 'id' | 'name' | 'platform'>[] = ( |
|
|
|
await this.accountService.accounts({ |
|
|
|
include: { platform: true }, |
|
|
|
where: { userId: user.id } |
|
|
|
}) |
|
|
|
).map(({ id, name, platform }) => { |
|
|
|
return { id, name, platform }; |
|
|
|
}); |
|
|
|
|
|
|
|
if (isDryRun) { |
|
|
|
accountsWithBalancesDto |
|
|
|
@ -888,7 +892,7 @@ export class ImportService { |
|
|
|
let order: |
|
|
|
| OrderWithAccount |
|
|
|
| (Omit<OrderWithAccount, 'account' | 'SymbolProfile' | 'tags'> & { |
|
|
|
account?: { id: string; name: string }; |
|
|
|
account?: Pick<AccountWithPlatform, 'id' | 'name' | 'platform'>; |
|
|
|
tags?: { id: string; name: string }[]; |
|
|
|
}); |
|
|
|
|
|
|
|
|