Browse Source
Bugfix/total fee calculation related to activities in custom currency (#6191)
* Fix total fee calculation related to activities in custom currency
* Update changelog
pull/6194/head
Thomas Kaul
1 day ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
7 additions and
6 deletions
-
CHANGELOG.md
-
apps/api/src/app/portfolio/portfolio.service.ts
|
|
|
@ -15,6 +15,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
- Restored the support for specific calendar year date ranges (`2024`, `2023`, `2022`, etc.) in the holdings table (experimental) |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed the total fee calculation in the holding detail dialog related to activities in a custom currency |
|
|
|
- Fixed the total fee calculation in the summary related to activities in a custom currency |
|
|
|
|
|
|
|
## 2.229.0 - 2026-01-11 |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
|
|
@ -792,7 +792,7 @@ export class PortfolioService { |
|
|
|
averagePrice, |
|
|
|
currency, |
|
|
|
dividendInBaseCurrency, |
|
|
|
fee, |
|
|
|
feeInBaseCurrency, |
|
|
|
firstBuyDate, |
|
|
|
grossPerformance, |
|
|
|
grossPerformancePercentage, |
|
|
|
@ -928,11 +928,7 @@ export class PortfolioService { |
|
|
|
dividendYieldPercent: dividendYieldPercent.toNumber(), |
|
|
|
dividendYieldPercentWithCurrencyEffect: |
|
|
|
dividendYieldPercentWithCurrencyEffect.toNumber(), |
|
|
|
feeInBaseCurrency: this.exchangeRateDataService.toCurrency( |
|
|
|
fee.toNumber(), |
|
|
|
SymbolProfile.currency, |
|
|
|
userCurrency |
|
|
|
), |
|
|
|
feeInBaseCurrency: feeInBaseCurrency.toNumber(), |
|
|
|
grossPerformance: grossPerformance?.toNumber(), |
|
|
|
grossPerformancePercent: grossPerformancePercentage?.toNumber(), |
|
|
|
grossPerformancePercentWithCurrencyEffect: |
|
|
|
|