Browse Source

Feature/improve icon of holdings tabs (#5842)

* Improve icon of holdings tabs

* Update changelog
pull/5752/merge
Thomas Kaul 3 days ago
committed by GitHub
parent
commit
674a96ce8c
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 6
      CHANGELOG.md
  2. 6
      apps/client/src/app/components/account-detail-dialog/account-detail-dialog.component.ts
  3. 2
      apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html
  4. 10
      apps/client/src/app/pages/home/home-page.component.ts
  5. 6
      apps/client/src/app/pages/zen/zen-page.component.ts

6
CHANGELOG.md

@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Extended the activities table menu with a _View Holding_ item - Extended the activities table menu with a _View Holding_ item
### Changed
- Improved the icon of the holdings tab on the home page
- Improved the icon of the holdings tab on the home page for the _Zen Mode_
- Improved the icon of the holdings tab in the account detail dialog
## 2.212.0 - 2025-10-29 ## 2.212.0 - 2025-10-29
### Added ### Added

6
apps/client/src/app/components/account-detail-dialog/account-detail-dialog.component.ts

@ -43,9 +43,9 @@ import { Big } from 'big.js';
import { format, parseISO } from 'date-fns'; import { format, parseISO } from 'date-fns';
import { addIcons } from 'ionicons'; import { addIcons } from 'ionicons';
import { import {
albumsOutline,
cashOutline, cashOutline,
swapVerticalOutline, swapVerticalOutline
walletOutline
} from 'ionicons/icons'; } from 'ionicons/icons';
import { isNumber } from 'lodash'; import { isNumber } from 'lodash';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
@ -129,7 +129,7 @@ export class GfAccountDetailDialogComponent implements OnDestroy, OnInit {
} }
}); });
addIcons({ cashOutline, swapVerticalOutline, walletOutline }); addIcons({ albumsOutline, cashOutline, swapVerticalOutline });
} }
public ngOnInit() { public ngOnInit() {

2
apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html

@ -98,7 +98,7 @@
> >
<mat-tab> <mat-tab>
<ng-template mat-tab-label> <ng-template mat-tab-label>
<ion-icon name="wallet-outline" /> <ion-icon name="albums-outline" />
<div class="d-none d-sm-block ml-2" i18n>Holdings</div> <div class="d-none d-sm-block ml-2" i18n>Holdings</div>
</ng-template> </ng-template>
<gf-holdings-table <gf-holdings-table

10
apps/client/src/app/pages/home/home-page.component.ts

@ -16,11 +16,11 @@ import { RouterModule } from '@angular/router';
import { IonIcon } from '@ionic/angular/standalone'; import { IonIcon } from '@ionic/angular/standalone';
import { addIcons } from 'ionicons'; import { addIcons } from 'ionicons';
import { import {
albumsOutline,
analyticsOutline, analyticsOutline,
bookmarkOutline, bookmarkOutline,
newspaperOutline, newspaperOutline,
readerOutline, readerOutline
walletOutline
} from 'ionicons/icons'; } from 'ionicons/icons';
import { DeviceDetectorService } from 'ngx-device-detector'; import { DeviceDetectorService } from 'ngx-device-detector';
import { Subject } from 'rxjs'; import { Subject } from 'rxjs';
@ -61,7 +61,7 @@ export class GfHomePageComponent implements OnDestroy, OnInit {
routerLink: internalRoutes.home.routerLink routerLink: internalRoutes.home.routerLink
}, },
{ {
iconName: 'wallet-outline', iconName: 'albums-outline',
label: internalRoutes.home.subRoutes.holdings.title, label: internalRoutes.home.subRoutes.holdings.title,
routerLink: internalRoutes.home.subRoutes.holdings.routerLink routerLink: internalRoutes.home.subRoutes.holdings.routerLink
}, },
@ -97,11 +97,11 @@ export class GfHomePageComponent implements OnDestroy, OnInit {
}); });
addIcons({ addIcons({
albumsOutline,
analyticsOutline, analyticsOutline,
bookmarkOutline, bookmarkOutline,
newspaperOutline, newspaperOutline,
readerOutline, readerOutline
walletOutline
}); });
} }

6
apps/client/src/app/pages/zen/zen-page.component.ts

@ -8,7 +8,7 @@ import { MatTabsModule } from '@angular/material/tabs';
import { RouterModule } from '@angular/router'; import { RouterModule } from '@angular/router';
import { IonIcon } from '@ionic/angular/standalone'; import { IonIcon } from '@ionic/angular/standalone';
import { addIcons } from 'ionicons'; import { addIcons } from 'ionicons';
import { analyticsOutline, walletOutline } from 'ionicons/icons'; import { albumsOutline, analyticsOutline } from 'ionicons/icons';
import { DeviceDetectorService } from 'ngx-device-detector'; import { DeviceDetectorService } from 'ngx-device-detector';
import { Subject } from 'rxjs'; import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators'; import { takeUntil } from 'rxjs/operators';
@ -43,7 +43,7 @@ export class GfZenPageComponent implements OnDestroy, OnInit {
routerLink: internalRoutes.zen.routerLink routerLink: internalRoutes.zen.routerLink
}, },
{ {
iconName: 'wallet-outline', iconName: 'albums-outline',
label: internalRoutes.zen.subRoutes.holdings.title, label: internalRoutes.zen.subRoutes.holdings.title,
routerLink: internalRoutes.zen.subRoutes.holdings.routerLink routerLink: internalRoutes.zen.subRoutes.holdings.routerLink
} }
@ -54,7 +54,7 @@ export class GfZenPageComponent implements OnDestroy, OnInit {
} }
}); });
addIcons({ analyticsOutline, walletOutline }); addIcons({ albumsOutline, analyticsOutline });
} }
public ngOnInit() { public ngOnInit() {

Loading…
Cancel
Save