Browse Source
Feature/Improve activities import by ISIN number (#3051)
* Improve activities import by ISIN number
* Update changelog
pull/3067/head^2
Søren Bjergmark
1 year ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with
8 additions and
12 deletions
-
CHANGELOG.md
-
apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
-
apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
|
|
@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
## Unreleased |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
|
|
- Improved the activities import by `isin` in the _Yahoo Finance_ service |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed an issue with the exchange rate calculation of (wealth) items in accounts |
|
|
|
|
|
@ -196,7 +196,9 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface { |
|
|
|
shortName: assetProfile.price.shortName, |
|
|
|
symbol: assetProfile.price.symbol |
|
|
|
}); |
|
|
|
response.symbol = assetProfile.price.symbol; |
|
|
|
response.symbol = this.convertFromYahooFinanceSymbol( |
|
|
|
assetProfile.price.symbol |
|
|
|
); |
|
|
|
|
|
|
|
if (assetSubClass === AssetSubClass.MUTUALFUND) { |
|
|
|
response.sectors = []; |
|
|
|
|
|
@ -38,17 +38,7 @@ export class YahooFinanceService implements DataProviderInterface { |
|
|
|
}: { |
|
|
|
symbol: string; |
|
|
|
}): Promise<Partial<SymbolProfile>> { |
|
|
|
const { assetClass, assetSubClass, currency, name } = |
|
|
|
await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol); |
|
|
|
|
|
|
|
return { |
|
|
|
assetClass, |
|
|
|
assetSubClass, |
|
|
|
currency, |
|
|
|
name, |
|
|
|
symbol, |
|
|
|
dataSource: this.getName() |
|
|
|
}; |
|
|
|
return this.yahooFinanceDataEnhancerService.getAssetProfile(symbol); |
|
|
|
} |
|
|
|
|
|
|
|
public getDataProviderInfo(): DataProviderInfo { |
|
|
|