Browse Source
Convert between ZAc and ZAR (#1471)
* Convert between ZAc and ZAR
* Update changelog
pull/1476/head
Delena Malan
2 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with
19 additions and
0 deletions
-
CHANGELOG.md
-
apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
|
|
@ -39,6 +39,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
- Added an indicator for excluded accounts in the accounts table |
|
|
|
- Added a blog post: _Black Friday 2022_ |
|
|
|
|
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed an issue with the currency inconsistency in the _Yahoo Finance_ service (convert from `ZAc` to `ZAR`) |
|
|
|
|
|
|
|
## 1.212.0 - 11.11.2022 |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
@ -206,6 +206,9 @@ export class YahooFinanceService implements DataProviderInterface { |
|
|
|
} else if (symbol === `${this.baseCurrency}ILA`) { |
|
|
|
// Convert ILS to ILA
|
|
|
|
marketPrice = new Big(marketPrice).mul(100).toNumber(); |
|
|
|
} else if (symbol === `${this.baseCurrency}ZAc`) { |
|
|
|
// Convert ZAR to ZAc (cents)
|
|
|
|
marketPrice = new Big(marketPrice).mul(100).toNumber(); |
|
|
|
} |
|
|
|
|
|
|
|
response[symbol][format(historicalItem.date, DATE_FORMAT)] = { |
|
|
@ -287,6 +290,18 @@ export class YahooFinanceService implements DataProviderInterface { |
|
|
|
.mul(100) |
|
|
|
.toNumber() |
|
|
|
}; |
|
|
|
} else if ( |
|
|
|
symbol === `${this.baseCurrency}ZAR` && |
|
|
|
yahooFinanceSymbols.includes(`${this.baseCurrency}ZAc=X`) |
|
|
|
) { |
|
|
|
// Convert ZAR to ZAc (cents)
|
|
|
|
response[`${this.baseCurrency}ZAc`] = { |
|
|
|
...response[symbol], |
|
|
|
currency: 'ZAc', |
|
|
|
marketPrice: new Big(response[symbol].marketPrice) |
|
|
|
.mul(100) |
|
|
|
.toNumber() |
|
|
|
}; |
|
|
|
} |
|
|
|
} |
|
|
|
|
|
|
|