fix(lib): create canShowDetails function

libs/ui/src/lib/holdings-table/holdings-table.component.html

@@ -181,13 +181,9 @@
     <tr
       *matRowDef="let row; columns: displayedColumns()"
       mat-row
-      [ngClass]="{
-        'cursor-pointer':
-          hasPermissionToOpenDetails() &&
-          !ignoreAssetSubClasses.includes(row.assetSubClass)
-      }"
+      [class.cursor-pointer]="canShowDetails(row)"
       (click)="
-        !ignoreAssetSubClasses.includes(row.assetSubClass) &&
+        canShowDetails(row) &&
           onOpenHoldingDialog({
             dataSource: row.dataSource,
             symbol: row.symbol

libs/ui/src/lib/holdings-table/holdings-table.component.ts

@@ -84,7 +84,10 @@ export class GfHoldingsTableComponent {
     return columns;
   });
 
-  protected readonly ignoreAssetSubClasses = [AssetSubClass.CASH];
+  protected readonly ignoreAssetSubClasses: AssetSubClass[] = [
+    AssetSubClass.CASH
+  ];
+
   protected readonly isLoading = computed(() => !this.holdings());
 
   constructor() {
@@ -102,13 +105,21 @@ export class GfHoldingsTableComponent {
     });
   }
 
-  public onOpenHoldingDialog({ dataSource, symbol }: AssetProfileIdentifier) {
-    if (this.hasPermissionToOpenDetails()) {
-      this.holdingClicked.emit({ dataSource, symbol });
-    }
+  protected canShowDetails(holding: PortfolioPosition): boolean {
+    return (
+      this.hasPermissionToOpenDetails() &&
+      !this.ignoreAssetSubClasses.includes(holding.assetSubClass)
+    );
+  }
+
+  protected onOpenHoldingDialog({
+    dataSource,
+    symbol
+  }: AssetProfileIdentifier) {
+    this.holdingClicked.emit({ dataSource, symbol });
   }
 
-  public onShowAllHoldings() {
+  protected onShowAllHoldings() {
     this.pageSize = Number.MAX_SAFE_INTEGER;
 
     setTimeout(() => {