From 6f70ee1c5bc1513d67d1753a520c6eb65e10e490 Mon Sep 17 00:00:00 2001 From: Shaunak Das <51281688+shaun-ak@users.noreply.github.com> Date: Sat, 7 Sep 2024 20:11:56 +0530 Subject: [PATCH] address pr comments --- .../src/app/components/admin-jobs/admin-jobs.component.ts | 3 ++- .../src/app/components/admin-users/admin-users.component.ts | 3 ++- .../src/app/components/admin-users/admin-users.module.ts | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/client/src/app/components/admin-jobs/admin-jobs.component.ts b/apps/client/src/app/components/admin-jobs/admin-jobs.component.ts index 6a8e304fc..be4b29111 100644 --- a/apps/client/src/app/components/admin-jobs/admin-jobs.component.ts +++ b/apps/client/src/app/components/admin-jobs/admin-jobs.component.ts @@ -51,9 +51,9 @@ export class AdminJobsComponent implements OnDestroy, OnInit { 'status', 'actions' ]; + public isLoading = false; public statusFilterOptions = QUEUE_JOB_STATUS_LIST; public user: User; - public isLoading = false; private unsubscribeSubject = new Subject(); @@ -140,6 +140,7 @@ export class AdminJobsComponent implements OnDestroy, OnInit { private fetchJobs(aStatus?: JobStatus[]) { this.isLoading = true; + this.adminService .fetchJobs({ status: aStatus }) .pipe(takeUntil(this.unsubscribeSubject)) diff --git a/apps/client/src/app/components/admin-users/admin-users.component.ts b/apps/client/src/app/components/admin-users/admin-users.component.ts index 2d77eb3a8..01310b03d 100644 --- a/apps/client/src/app/components/admin-users/admin-users.component.ts +++ b/apps/client/src/app/components/admin-users/admin-users.component.ts @@ -32,8 +32,8 @@ export class AdminUsersComponent implements OnDestroy, OnInit { public hasPermissionForSubscription: boolean; public hasPermissionToImpersonateAllUsers: boolean; public info: InfoItem; - public user: User; public isLoading = false; + public user: User; private unsubscribeSubject = new Subject(); @@ -144,6 +144,7 @@ export class AdminUsersComponent implements OnDestroy, OnInit { private fetchAdminData() { this.isLoading = true; + this.adminService .fetchAdminData() .pipe(takeUntil(this.unsubscribeSubject)) diff --git a/apps/client/src/app/components/admin-users/admin-users.module.ts b/apps/client/src/app/components/admin-users/admin-users.module.ts index b5b323da9..fcf25c8b5 100644 --- a/apps/client/src/app/components/admin-users/admin-users.module.ts +++ b/apps/client/src/app/components/admin-users/admin-users.module.ts @@ -19,8 +19,8 @@ import { AdminUsersComponent } from './admin-users.component'; GfValueComponent, MatButtonModule, MatMenuModule, - NgxSkeletonLoaderModule, - MatTableModule + MatTableModule, + NgxSkeletonLoaderModule ], schemas: [CUSTOM_ELEMENTS_SCHEMA] })