From 7078dd5c72926268a1dfc0321c5653e8c7c5ae97 Mon Sep 17 00:00:00 2001
From: dw-0 <th33xitus@gmail.com>
Date: Sun, 6 Oct 2024 11:22:18 +0200
Subject: [PATCH] style: mark comments as TODOs

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
---
 .eslintrc.json            | 2 +-
 apps/client/tsconfig.json | 5 +++--
 libs/ui/tsconfig.json     | 9 +++++----
 tsconfig.base.json        | 3 +--
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index f06f97b71..c2e6b8079 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -147,7 +147,7 @@
         "@typescript-eslint/consistent-type-definitions": "warn",
         "@typescript-eslint/prefer-function-type": "warn",
         "@typescript-eslint/no-empty-function": "warn",
-        "@typescript-eslint/prefer-nullish-coalescing": "warn", // requires strictNullChecks: true
+        "@typescript-eslint/prefer-nullish-coalescing": "warn", // TODO: Requires strictNullChecks: true
         "@typescript-eslint/consistent-type-assertions": "warn",
         "@typescript-eslint/prefer-optional-chain": "warn",
         "@typescript-eslint/consistent-indexed-object-style": "warn",
diff --git a/apps/client/tsconfig.json b/apps/client/tsconfig.json
index 88357aa9b..1dd30aad1 100644
--- a/apps/client/tsconfig.json
+++ b/apps/client/tsconfig.json
@@ -15,8 +15,9 @@
   ],
   "angularCompilerOptions": {
     "strictInjectionParameters": true,
-    "strictInputAccessModifiers": false, // todo: enable strict input access modifiers
-    "strictTemplates": false // todo: enable strict templates
+    // TODO: Enable stricter rules for this project
+    "strictInputAccessModifiers": false,
+    "strictTemplates": false
   },
   "compilerOptions": {
     "target": "es2020"
diff --git a/libs/ui/tsconfig.json b/libs/ui/tsconfig.json
index 6be2dcc3e..3ec4903b5 100644
--- a/libs/ui/tsconfig.json
+++ b/libs/ui/tsconfig.json
@@ -14,10 +14,11 @@
     }
   ],
   "compilerOptions": {
-    "strict": false, // remove once solved in tsconfig.base.json
-    "noImplicitReturns": true, // remove once solved in tsconfig.base.json
-    "noFallthroughCasesInSwitch": true, // remove once solved in tsconfig.base.json
-    "target": "es2020"
+    "target": "es2020",
+    // TODO: Remove once solved in tsconfig.base.json
+    "strict": false,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true
   },
   "angularCompilerOptions": {
     "strictInjectionParameters": true,
diff --git a/tsconfig.base.json b/tsconfig.base.json
index 521206d3d..e977a9596 100644
--- a/tsconfig.base.json
+++ b/tsconfig.base.json
@@ -23,7 +23,6 @@
     },
     "noFallthroughCasesInSwitch": true,
     "forceConsistentCasingInFileNames": true,
-    // set to true to enable stricter type checking for this project
     "strict": false,
     "strictNullChecks": false,
     "strictPropertyInitialization": false,
@@ -34,7 +33,7 @@
     "noPropertyAccessFromIndexSignature": false,
     "noUnusedLocals": false,
     "noUnusedParameters": false,
-    "allowUnreachableCode": true // set to false for stricter type checking
+    "allowUnreachableCode": true
   },
   "exclude": ["node_modules", "tmp"]
 }