Browse Source
Task/set change detection strategy to OnPush in activities page (#7248)
* Set change detection strategy to OnPush
* Update changelog
pull/7282/head
Arjun jaiswal
6 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
6 additions and
0 deletions
-
CHANGELOG.md
-
apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
|
|
@ -15,9 +15,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
|
- Improved the user account deletion flow in the user settings of the user account page |
|
|
- Improved the user account deletion flow in the user settings of the user account page |
|
|
- Improved the date formatting of the first activity in the historical market data table of the admin control panel |
|
|
- Improved the date formatting of the first activity in the historical market data table of the admin control panel |
|
|
|
|
|
- Set the change detection strategy to `OnPush` in the activities page |
|
|
- Set the change detection strategy to `OnPush` in the allocations page |
|
|
- Set the change detection strategy to `OnPush` in the allocations page |
|
|
- Set the change detection strategy to `OnPush` in the analysis page |
|
|
- Set the change detection strategy to `OnPush` in the analysis page |
|
|
- Set the change detection strategy to `OnPush` in the portfolio holdings page |
|
|
- Set the change detection strategy to `OnPush` in the portfolio holdings page |
|
|
|
|
|
- Set the change detection strategy to `OnPush` in the activities page |
|
|
- Set the change detection strategy to `OnPush` in the _FIRE_ page |
|
|
- Set the change detection strategy to `OnPush` in the _FIRE_ page |
|
|
- Set the change detection strategy to `OnPush` in the users section of the admin control panel |
|
|
- Set the change detection strategy to `OnPush` in the users section of the admin control panel |
|
|
- Renamed the `SymbolProfileOverrides` _Prisma_ data model to `AssetProfileOverrides` while keeping the database table name |
|
|
- Renamed the `SymbolProfileOverrides` _Prisma_ data model to `AssetProfileOverrides` while keeping the database table name |
|
|
|
|
|
@ -16,6 +16,7 @@ import { GfFabComponent } from '@ghostfolio/ui/fab'; |
|
|
import { DataService } from '@ghostfolio/ui/services'; |
|
|
import { DataService } from '@ghostfolio/ui/services'; |
|
|
|
|
|
|
|
|
import { |
|
|
import { |
|
|
|
|
|
ChangeDetectionStrategy, |
|
|
ChangeDetectorRef, |
|
|
ChangeDetectorRef, |
|
|
Component, |
|
|
Component, |
|
|
DestroyRef, |
|
|
DestroyRef, |
|
|
@ -38,6 +39,7 @@ import { GfImportActivitiesDialogComponent } from './import-activities-dialog/im |
|
|
import { ImportActivitiesDialogParams } from './import-activities-dialog/interfaces/interfaces'; |
|
|
import { ImportActivitiesDialogParams } from './import-activities-dialog/interfaces/interfaces'; |
|
|
|
|
|
|
|
|
@Component({ |
|
|
@Component({ |
|
|
|
|
|
changeDetection: ChangeDetectionStrategy.OnPush, |
|
|
imports: [ |
|
|
imports: [ |
|
|
GfActivitiesTableComponent, |
|
|
GfActivitiesTableComponent, |
|
|
GfFabComponent, |
|
|
GfFabComponent, |
|
|
@ -112,6 +114,8 @@ export class GfActivitiesPageComponent implements OnInit { |
|
|
.pipe(takeUntilDestroyed(this.destroyRef)) |
|
|
.pipe(takeUntilDestroyed(this.destroyRef)) |
|
|
.subscribe((impersonationId) => { |
|
|
.subscribe((impersonationId) => { |
|
|
this.hasImpersonationId = !!impersonationId; |
|
|
this.hasImpersonationId = !!impersonationId; |
|
|
|
|
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
}); |
|
|
}); |
|
|
|
|
|
|
|
|
this.userService.stateChanged |
|
|
this.userService.stateChanged |
|
|
|