Browse Source

feat(lib): change deviceType to computed signal

pull/6337/head
KenTandrian 2 months ago
parent
commit
74940efd36
  1. 5
      libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.spec.ts
  2. 17
      libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts

5
libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.spec.ts

@ -1,5 +1,6 @@
import { DataService } from '@ghostfolio/ui/services';
import { signal } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { FormBuilder } from '@angular/forms';
import { MatDialog } from '@angular/material/dialog';
@ -27,7 +28,9 @@ describe('GfHistoricalMarketDataEditorComponent', () => {
{ provide: DataService, useValue: {} },
{
provide: DeviceDetectorService,
useValue: { getDeviceInfo: () => ({ deviceType: 'desktop' }) }
useValue: {
deviceInfo: signal({ deviceType: 'desktop' })
}
},
{ provide: MatDialog, useValue: {} },
{ provide: MatSnackBar, useValue: {} }

17
libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor.component.ts

@ -14,6 +14,7 @@ import {
Component,
computed,
EventEmitter,
inject,
input,
Input,
OnChanges,
@ -73,7 +74,6 @@ export class GfHistoricalMarketDataEditorComponent
@Output() marketDataChanged = new EventEmitter<boolean>();
public deviceType: string;
public historicalDataForm = this.formBuilder.group({
historicalData: this.formBuilder.group({
csvString: ''
@ -97,17 +97,18 @@ export class GfHistoricalMarketDataEditorComponent
getDateFormatString(this.locale())
);
private unsubscribeSubject = new Subject<void>();
private readonly deviceDetectorService = inject(DeviceDetectorService);
private readonly deviceType = computed(
() => this.deviceDetectorService.deviceInfo().deviceType
);
private readonly unsubscribeSubject = new Subject<void>();
public constructor(
private dataService: DataService,
private deviceService: DeviceDetectorService,
private dialog: MatDialog,
private formBuilder: FormBuilder,
private snackBar: MatSnackBar
) {
this.deviceType = this.deviceService.getDeviceInfo().deviceType;
}
) {}
public ngOnInit() {
this.initializeHistoricalDataForm();
@ -231,8 +232,8 @@ export class GfHistoricalMarketDataEditorComponent
symbol: this.symbol,
user: this.user
},
height: this.deviceType === 'mobile' ? '98vh' : '80vh',
width: this.deviceType === 'mobile' ? '100vw' : '50rem'
height: this.deviceType() === 'mobile' ? '98vh' : '80vh',
width: this.deviceType() === 'mobile' ? '100vw' : '50rem'
});
dialogRef

Loading…
Cancel
Save