From 770634cfe120d19d9e56379c8e51c9b043de0639 Mon Sep 17 00:00:00 2001 From: Aditya Pawar Date: Sun, 12 Oct 2025 15:45:56 +0530 Subject: [PATCH] fix : address all PR comments --- apps/client/src/app/app.module.ts | 2 -- apps/client/src/app/components/footer/footer.component.ts | 6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/apps/client/src/app/app.module.ts b/apps/client/src/app/app.module.ts index 565400739..63de8fca7 100644 --- a/apps/client/src/app/app.module.ts +++ b/apps/client/src/app/app.module.ts @@ -18,7 +18,6 @@ import { BrowserModule } from '@angular/platform-browser'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { ServiceWorkerModule } from '@angular/service-worker'; import { provideIonicAngular } from '@ionic/angular/standalone'; -import { IonIcon } from '@ionic/angular/standalone'; import { provideMarkdown } from 'ngx-markdown'; import { provideNgxSkeletonLoader } from 'ngx-skeleton-loader'; import { NgxStripeModule, STRIPE_PUBLISHABLE_KEY } from 'ngx-stripe'; @@ -49,7 +48,6 @@ export function NgxStripeFactory(): string { GfFooterComponent, GfHeaderComponent, GfNotificationModule, - IonIcon, MatAutocompleteModule, MatChipsModule, MatNativeDateModule, diff --git a/apps/client/src/app/components/footer/footer.component.ts b/apps/client/src/app/components/footer/footer.component.ts index 4eb47d3c0..a5820832e 100644 --- a/apps/client/src/app/components/footer/footer.component.ts +++ b/apps/client/src/app/components/footer/footer.component.ts @@ -18,11 +18,11 @@ import { openOutline } from 'ionicons/icons'; @Component({ changeDetection: ChangeDetectionStrategy.OnPush, + imports: [CommonModule, GfLogoComponent, IonIcon, RouterModule], + schemas: [CUSTOM_ELEMENTS_SCHEMA], selector: 'gf-footer', - templateUrl: './footer.component.html', styleUrls: ['./footer.component.scss'], - imports: [CommonModule, GfLogoComponent, IonIcon, RouterModule], - schemas: [CUSTOM_ELEMENTS_SCHEMA] + templateUrl: './footer.component.html' }) export class GfFooterComponent implements OnChanges { @Input() public info: InfoItem;