From 78ededd098bcfd63a9369a9657c6c25c705653d3 Mon Sep 17 00:00:00 2001 From: Kenrick Tandrian <60643640+KenTandrian@users.noreply.github.com> Date: Thu, 26 Feb 2026 19:08:42 +0000 Subject: [PATCH] feat(lib): change tags to input signal --- .../portfolio-filter-form.component.html | 2 +- .../portfolio-filter-form/portfolio-filter-form.component.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html index 63933c735..f5dbac698 100644 --- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html +++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.html @@ -53,7 +53,7 @@ Tag - @for (tag of tags; track tag.id) { + @for (tag of tags(); track tag.id) { {{ tag.label }} } diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts index 5e9b7336f..4dc8d7bf7 100644 --- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts +++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts @@ -57,12 +57,12 @@ import { PortfolioFilterFormValue } from './interfaces'; export class GfPortfolioFilterFormComponent implements ControlValueAccessor, OnInit, OnChanges { - @Input() tags: Filter[] = []; @Input() disabled = false; public readonly accounts = input([]); public readonly assetClasses = input([]); public readonly holdings = input([]); + public readonly tags = input([]); public filterForm: FormGroup<{ account: FormControl; @@ -123,7 +123,7 @@ export class GfPortfolioFilterFormComponent const tagControl = this.filterForm.get('tag'); - if (this.tags.length === 0) { + if (this.tags().length === 0) { tagControl?.disable({ emitEvent: false }); } else if (!this.disabled) { tagControl?.enable({ emitEvent: false });