From 791000a46eb28c6822fbee741d4916d775f10dec Mon Sep 17 00:00:00 2001 From: adityagarud Date: Sat, 4 Oct 2025 21:52:55 +0530 Subject: [PATCH] fix: address all review comments - add blank lines, move constants, update changelog --- CHANGELOG.md | 6 +++--- libs/ui/src/lib/assistant/assistant.component.ts | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c282f0a0..6c9fd1ddd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,14 +5,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## 2.206.0 - 2025-01-27 +## Unreleased ### Added -- Auto-preselect first search result in assistant for improved keyboard navigation - ### Changed +- Auto-preselect first search result in assistant for improved keyboard navigation + - Localized the number formatting in the settings dialog to customize the rule thresholds of the _X-ray_ page - Improved the usability of the _Cancel_ / _Close_ buttons in the create watchlist item dialog - Refactored the `fireWealth` from `number` type to a structured object in the summary of the portfolio details endpoint diff --git a/libs/ui/src/lib/assistant/assistant.component.ts b/libs/ui/src/lib/assistant/assistant.component.ts index 41d5c598b..ef1cb2d8a 100644 --- a/libs/ui/src/lib/assistant/assistant.component.ts +++ b/libs/ui/src/lib/assistant/assistant.component.ts @@ -169,12 +169,12 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit { }; public tags: Filter[] = []; + private readonly PRESELECTION_DELAY = 100; + private keyManager: FocusKeyManager; private preselectionTimeout: ReturnType; private unsubscribeSubject = new Subject(); - private readonly PRESELECTION_DELAY = 100; - private filterTypes: Filter['type'][] = [ 'ACCOUNT', 'ASSET_CLASS', @@ -349,6 +349,7 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit { next: (searchResults) => { this.searchResults = searchResults; this.preselectFirstItem(); + this.changeDetectorRef.markForCheck(); }, error: (error) => {