From 799da6831dfb8fda97393cc7b20fb3637c8237d3 Mon Sep 17 00:00:00 2001 From: mister-ideas <36502095+mister-ideas@users.noreply.github.com> Date: Mon, 19 Oct 2026 13:26:36 +0200 Subject: [PATCH] Feature/use year-to-date as the fallback date range in the client --- .../home-holdings/home-holdings.component.ts | 4 ++-- .../home-overview/home-overview.component.ts | 4 ++-- .../portfolio/analysis/analysis-page.component.ts | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/apps/client/src/app/components/home-holdings/home-holdings.component.ts b/apps/client/src/app/components/home-holdings/home-holdings.component.ts index 333a24d5d6..c20191f750 100644 --- a/apps/client/src/app/components/home-holdings/home-holdings.component.ts +++ b/apps/client/src/app/components/home-holdings/home-holdings.component.ts @@ -1,7 +1,7 @@ import { UserService } from '@ghostfolio/client/services/user/user.service'; import { DEFAULT_CURRENCY, - DEFAULT_DATE_RANGE, + DEFAULT_USER_DATE_RANGE, DEFAULT_LOCALE } from '@ghostfolio/common/config'; import { @@ -66,7 +66,7 @@ export class GfHomeHoldingsComponent implements OnInit { }); protected readonly dateRange = computed(() => { - return this.user()?.settings?.dateRange ?? DEFAULT_DATE_RANGE; + return this.user()?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE; }); protected readonly deviceType = computed(() => { diff --git a/apps/client/src/app/components/home-overview/home-overview.component.ts b/apps/client/src/app/components/home-overview/home-overview.component.ts index c7b880efce..a9a14348a8 100644 --- a/apps/client/src/app/components/home-overview/home-overview.component.ts +++ b/apps/client/src/app/components/home-overview/home-overview.component.ts @@ -4,7 +4,7 @@ import { ImpersonationStorageService } from '@ghostfolio/client/services/imperso import { UserService } from '@ghostfolio/client/services/user/user.service'; import { DEFAULT_CURRENCY, - DEFAULT_DATE_RANGE, + DEFAULT_USER_DATE_RANGE, DEFAULT_LOCALE, NUMERICAL_PRECISION_THRESHOLD_6_FIGURES } from '@ghostfolio/common/config'; @@ -191,7 +191,7 @@ export class GfHomeOverviewComponent implements OnInit { this.dataService .fetchPortfolioPerformance({ - range: userSettings?.dateRange ?? DEFAULT_DATE_RANGE + range: userSettings?.dateRange ?? DEFAULT_USER_DATE_RANGE }) .pipe(takeUntilDestroyed(this.destroyRef)) .subscribe(({ chart, errors, performance }) => { diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts index 8ba3f0fd8a..cd1b20cf5d 100644 --- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts +++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -1,7 +1,7 @@ import { GfBenchmarkComparatorComponent } from '@ghostfolio/client/components/benchmark-comparator/benchmark-comparator.component'; import { UserService } from '@ghostfolio/client/services/user/user.service'; import { - DEFAULT_DATE_RANGE, + DEFAULT_USER_DATE_RANGE, NUMERICAL_PRECISION_THRESHOLD_6_FIGURES } from '@ghostfolio/common/config'; import { SubscriptionType } from '@ghostfolio/common/enums'; @@ -249,12 +249,12 @@ export class GfAnalysisPageComponent implements OnInit { dividends: this.dataService.fetchDividends({ filters: this.userService.getFilters(), groupBy: this.mode(), - range: this.user?.settings?.dateRange ?? DEFAULT_DATE_RANGE + range: this.user?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE }), investments: this.dataService.fetchInvestments({ filters: this.userService.getFilters(), groupBy: this.mode(), - range: this.user?.settings?.dateRange ?? DEFAULT_DATE_RANGE + range: this.user?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE }) }) .pipe(takeUntilDestroyed(this.destroyRef)) @@ -323,7 +323,7 @@ export class GfAnalysisPageComponent implements OnInit { .fetchPortfolioPerformance({ filters: this.userService.getFilters(), groupBy: 'year', - range: this.user?.settings?.dateRange ?? DEFAULT_DATE_RANGE + range: this.user?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE }) .pipe(takeUntilDestroyed(this.destroyRef)) .subscribe(({ chart }) => { @@ -353,7 +353,7 @@ export class GfAnalysisPageComponent implements OnInit { this.dataService .fetchPortfolioPerformance({ filters: this.userService.getFilters(), - range: this.user?.settings?.dateRange ?? DEFAULT_DATE_RANGE + range: this.user?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE }) .pipe(takeUntilDestroyed(this.destroyRef)) .subscribe(({ chart, dateOfFirstActivity, performance }) => { @@ -482,7 +482,7 @@ export class GfAnalysisPageComponent implements OnInit { dataSource, symbol, filters: this.userService.getFilters(), - range: this.user?.settings?.dateRange ?? DEFAULT_DATE_RANGE, + range: this.user?.settings?.dateRange ?? DEFAULT_USER_DATE_RANGE, startDate: this.dateOfFirstActivity }) .pipe(takeUntilDestroyed(this.destroyRef))