From 7a6f54ab3b2d1a32d3676c0e391a21bb4b795d0f Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 6 Sep 2026 10:22:54 +0200
Subject: [PATCH] Feature/simplified mode in holdings table component (#7830)

* Add simplified mode to holdings table component

* Update changelog
---
 CHANGELOG.md                                  |  4 ++++
 .../holdings-table.component.html             | 18 ++++++++++------
 .../holdings-table.component.stories.ts       | 15 +++++++++++++
 .../holdings-table.component.ts               | 21 +++++++++++++++++--
 4 files changed, 50 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 992af4047..19baa4cc3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Added
+
+- Added a simplified mode to the holdings table component
+
 ### Changed
 
 - Made the details of holdings excluded from analysis accessible via the activities table
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.html b/libs/ui/src/lib/holdings-table/holdings-table.component.html
index e66dac725..2ed948478 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.html
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.html
@@ -3,9 +3,9 @@
     class="gf-table w-100"
     mat-table
     matSort
-    matSortActive="allocationInPercentage"
-    matSortDirection="desc"
     [dataSource]="dataSource"
+    [matSortActive]="sortActive()"
+    [matSortDirection]="sortDirection()"
   >
     <ng-container matColumnDef="icon" sticky>
       <th *matHeaderCellDef class="px-1" mat-header-cell></th>
@@ -34,9 +34,11 @@
             <span>({{ element.assetProfile.assetSubClassLabel }})</span>
           }
         </div>
-        <div>
-          <small class="text-muted">{{ element.assetProfile.symbol }}</small>
-        </div>
+        @if (mode() === 'default') {
+          <div>
+            <small class="text-muted">{{ element.assetProfile.symbol }}</small>
+          </div>
+        }
       </td>
     </ng-container>
 
@@ -181,7 +183,11 @@
       </td>
     </ng-container>
 
-    <tr *matHeaderRowDef="displayedColumns()" mat-header-row></tr>
+    <tr
+      *matHeaderRowDef="displayedColumns()"
+      mat-header-row
+      [class.d-none]="mode() === 'simple'"
+    ></tr>
     <tr
       *matRowDef="let row; columns: displayedColumns()"
       mat-row
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.stories.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.stories.ts
index 8748a830f..126b9ced1 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.stories.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.stories.ts
@@ -9,6 +9,8 @@ import type { Meta, StoryObj } from '@storybook/angular';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
 import { GfEntityLogoComponent } from '../entity-logo';
+import { EntityLogoImageSourceService } from '../entity-logo/entity-logo-image-source.service';
+import { EntityLogoImageSourceServiceMock } from '../mocks/entity-logo-image-source.service.mock';
 import { holdings } from '../mocks/holdings';
 import { GfValueComponent } from '../value';
 import { GfHoldingsTableComponent } from './holdings-table.component';
@@ -28,6 +30,12 @@ export default {
         MatSortModule,
         MatTableModule,
         NgxSkeletonLoaderModule
+      ],
+      providers: [
+        {
+          provide: EntityLogoImageSourceService,
+          useValue: new EntityLogoImageSourceServiceMock()
+        }
       ]
     })
   ]
@@ -56,3 +64,10 @@ export const Default: Story = {
     pageSize: Number.MAX_SAFE_INTEGER
   }
 };
+
+export const Simple: Story = {
+  args: {
+    ...Default.args,
+    mode: 'simple'
+  }
+};
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index 1bbfa515b..ddf6a2f22 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -22,7 +22,7 @@ import {
 import { MatButtonModule } from '@angular/material/button';
 import { MatDialogModule } from '@angular/material/dialog';
 import { MatPaginator, MatPaginatorModule } from '@angular/material/paginator';
-import { MatSort, MatSortModule } from '@angular/material/sort';
+import { MatSort, MatSortModule, SortDirection } from '@angular/material/sort';
 import { MatTableDataSource, MatTableModule } from '@angular/material/table';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
@@ -52,6 +52,7 @@ export class GfHoldingsTableComponent {
   public readonly hasPermissionToShowValues = input(true);
   public readonly holdings = input.required<PortfolioPosition[] | undefined>();
   public readonly locale = input(getLocale());
+  public readonly mode = input<'default' | 'simple'>('default');
   public readonly pageSize = model(Number.MAX_SAFE_INTEGER);
 
   public readonly holdingClicked = output<AssetProfileIdentifier>();
@@ -62,6 +63,10 @@ export class GfHoldingsTableComponent {
   protected readonly dataSource = new MatTableDataSource<PortfolioPosition>([]);
 
   protected readonly displayedColumns = computed(() => {
+    if (this.mode() === 'simple') {
+      return ['icon', 'nameWithSymbol', 'performanceInPercentage'];
+    }
+
     const columns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity'];
 
     if (this.hasPermissionToShowQuantities()) {
@@ -82,7 +87,19 @@ export class GfHoldingsTableComponent {
     return columns;
   });
 
-  protected readonly isLoading = computed(() => !this.holdings());
+  protected readonly isLoading = computed(() => {
+    return !this.holdings();
+  });
+
+  protected readonly sortActive = computed(() => {
+    return this.mode() === 'default'
+      ? 'allocationInPercentage'
+      : 'assetProfile.name';
+  });
+
+  protected readonly sortDirection = computed<SortDirection>(() => {
+    return this.mode() === 'default' ? 'desc' : 'asc';
+  });
 
   public constructor() {
     this.dataSource.sortingDataAccessor = getLowercase;