From 0be7fa960ec5cb5745b65d76f8c5bdcb6b3f22c6 Mon Sep 17 00:00:00 2001
From: Dan <dan@ddev.ch>
Date: Thu, 20 Feb 2025 19:56:15 +0100
Subject: [PATCH 1/2] Add colorSIgn & fix calculation

---
 libs/ui/src/lib/holdings-table/holdings-table.component.html | 2 ++
 libs/ui/src/lib/holdings-table/holdings-table.component.ts   | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.html b/libs/ui/src/lib/holdings-table/holdings-table.component.html
index b7145970e..9773bcbc5 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.html
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.html
@@ -184,6 +184,7 @@
       <td *matFooterCellDef class="px-1" mat-footer-cell>
         <div class="d-flex justify-content-end">
           <gf-value
+            [colorizeSign]="true"
             [isCurrency]="true"
             [locale]="locale"
             [value]="totalChange"
@@ -219,6 +220,7 @@
       <td *matFooterCellDef class="px-1" mat-footer-cell>
         <div class="d-flex justify-content-end">
           <gf-value
+            [colorizeSign]="true"
             [isPercent]="true"
             [locale]="locale"
             [value]="totalChangePercentage"
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index 6c3a63029..a294d4c33 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -98,11 +98,11 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
     this.dataSource.paginator = this.paginator;
     this.dataSource.sort = this.sort;
     this.totalValue = this.dataSource.data.reduce(
-      (sum, current) => sum + current.valueInBaseCurrency,
+      (sum, current) => (sum += current.valueInBaseCurrency),
       0
     );
     this.totalChange = this.dataSource.data.reduce(
-      (sum, current) => sum + current.netPerformancePercentWithCurrencyEffect,
+      (sum, current) => (sum += current.netPerformanceWithCurrencyEffect),
       0
     );
     this.totalChangePercentage = (this.totalChange / this.totalValue) * 100;

From e9285927785738170fc7345b195f8a49e41a13bc Mon Sep 17 00:00:00 2001
From: Dan <dan@ddev.ch>
Date: Thu, 20 Feb 2025 20:00:53 +0100
Subject: [PATCH 2/2] Another fix in the calculation

---
 libs/ui/src/lib/holdings-table/holdings-table.component.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index a294d4c33..d5b5d2475 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -105,7 +105,8 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
       (sum, current) => (sum += current.netPerformanceWithCurrencyEffect),
       0
     );
-    this.totalChangePercentage = (this.totalChange / this.totalValue) * 100;
+    this.totalChangePercentage =
+      this.totalChange / (this.totalValue - this.totalChange);
 
     if (this.holdings) {
       this.isLoading = false;