Fix tests

apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@@ -163,7 +163,7 @@ export abstract class PortfolioCalculator {
     positions: TimelinePosition[]
   ): PortfolioSnapshot;
 
-  public async computeSnapshot(
+  private async computeSnapshot(
     start: Date,
     end?: Date
   ): Promise<PortfolioSnapshot> {

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-baln-buy-and-sell-in-two-activities.spec.ts

@@ -131,9 +131,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2021-11-22')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2021-11-22')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-baln-buy-and-sell.spec.ts

@@ -116,9 +116,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2021-11-22')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2021-11-22')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-baln-buy.spec.ts

@@ -101,9 +101,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2021-11-30')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2021-11-30')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts

@@ -129,9 +129,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2015-01-01')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2015-01-01')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-fee.spec.ts

@@ -97,9 +97,7 @@ describe('PortfolioCalculator', () => {
         userId: userDummyData.id
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2021-11-30')
-      );
 
       spy.mockRestore();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-googl-buy.spec.ts

@@ -114,9 +114,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2023-01-03')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2023-01-03')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-item.spec.ts

@@ -97,9 +97,7 @@ describe('PortfolioCalculator', () => {
         userId: userDummyData.id
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2022-01-01')
-      );
 
       spy.mockRestore();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-msft-buy-with-dividend.spec.ts

@@ -125,9 +125,7 @@ describe('PortfolioCalculator', () => {
         userId: userDummyData.id
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2023-07-10')
-      );
 
       spy.mockRestore();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-no-orders.spec.ts

@@ -79,8 +79,7 @@ describe('PortfolioCalculator', () => {
 
       const chartData = await portfolioCalculator.getChartData({ start });
 
-      const portfolioSnapshot =
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        await portfolioCalculator.computeSnapshot(start);
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-novn-buy-and-sell-partially.spec.ts

@@ -116,9 +116,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2022-03-07')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2022-03-07')
-      );
 
       const investments = portfolioCalculator.getInvestments();
 

apps/api/src/app/portfolio/calculator/twr/portfolio-calculator-novn-buy-and-sell.spec.ts

@@ -116,9 +116,7 @@ describe('PortfolioCalculator', () => {
         start: parseDate('2022-03-07')
       });
 
-      const portfolioSnapshot = await portfolioCalculator.computeSnapshot(
+      const portfolioSnapshot = await portfolioCalculator.getSnapshot();
-        parseDate('2022-03-07')
-      );
 
       const investments = portfolioCalculator.getInvestments();