From 7c11da4be2fdcb994900fd917baef6ea530971fa Mon Sep 17 00:00:00 2001 From: KenTandrian Date: Tue, 6 Oct 2026 11:20:10 +0700 Subject: [PATCH] Task/widen input types in dialog header tables and benchmark comparator Widen input types in dialog header, tables, and benchmark comparator Part of #7393 --- .../benchmark-comparator/benchmark-comparator.component.ts | 4 +++- libs/ui/src/lib/accounts-table/accounts-table.component.ts | 4 +++- libs/ui/src/lib/dialog-header/dialog-header.component.ts | 2 +- libs/ui/src/lib/holdings-table/holdings-table.component.ts | 4 +++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts b/apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts index 72241f0454..93d5351f63 100644 --- a/apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts +++ b/apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.ts @@ -72,7 +72,9 @@ export class GfBenchmarkComparatorComponent implements OnChanges, OnDestroy { public readonly benchmarks = input[]>(); public readonly colorScheme = input(); public readonly isLoading = input(); - public readonly locale = input(getLocale()); + public readonly locale = input(getLocale(), { + transform: (value?: string) => value ?? getLocale() + }); public readonly performanceDataItems = input.required(); public readonly user = input(); diff --git a/libs/ui/src/lib/accounts-table/accounts-table.component.ts b/libs/ui/src/lib/accounts-table/accounts-table.component.ts index e986932906..3c667db922 100644 --- a/libs/ui/src/lib/accounts-table/accounts-table.component.ts +++ b/libs/ui/src/lib/accounts-table/accounts-table.component.ts @@ -62,7 +62,9 @@ export class GfAccountsTableComponent { public readonly hasPermissionToDeleteAccount = input(); public readonly hasPermissionToOpenDetails = input(true); public readonly hasPermissionToUpdateAccount = input(); - public readonly locale = input(getLocale()); + public readonly locale = input(getLocale(), { + transform: (value?: string) => value ?? getLocale() + }); public readonly showActions = input(); public readonly showActivitiesCount = input(true); public readonly showAllocationInPercentage = input(); diff --git a/libs/ui/src/lib/dialog-header/dialog-header.component.ts b/libs/ui/src/lib/dialog-header/dialog-header.component.ts index 4868b22b89..2aa56ce2dd 100644 --- a/libs/ui/src/lib/dialog-header/dialog-header.component.ts +++ b/libs/ui/src/lib/dialog-header/dialog-header.component.ts @@ -22,7 +22,7 @@ import { close } from 'ionicons/icons'; export class GfDialogHeaderComponent { @Input() deviceType: string; @Input() position: 'center' | 'left' = 'left'; - @Input() title: string; + @Input() title?: string | null; @Output() closeButtonClicked = new EventEmitter(); diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 1894260b78..768c0f5fab 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -54,7 +54,9 @@ export class GfHoldingsTableComponent { public readonly hasPermissionToShowQuantities = input(true); public readonly hasPermissionToShowValues = input(true); public readonly holdings = input.required(); - public readonly locale = input(getLocale()); + public readonly locale = input(getLocale(), { + transform: (value?: string) => value ?? getLocale() + }); public readonly mode = input<'default' | 'simple'>('default'); public readonly pageSize = model(Number.MAX_SAFE_INTEGER);