From 7dc74fe6812cf1efe85d19f0713e79df06200b8d Mon Sep 17 00:00:00 2001
From: Vansh <140736931+Vansh-Parate@users.noreply.github.com>
Date: Tue, 28 Oct 2025 12:40:35 +0530
Subject: [PATCH] Task/refactor column definitions in AI service (#5834)

* Refactor column definitions in AI service

* Update changelog
---
 CHANGELOG.md                                |  2 +
 apps/api/src/app/endpoints/ai/ai.service.ts | 79 ++++++++++++++++-----
 2 files changed, 64 insertions(+), 17 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1024336b3..220b29036 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Refactored the generation of the holdings table in the _Copy AI prompt to clipboard for analysis_ action on the analysis page (experimental)
+- Refactored the generation of the holdings table in the _Copy portfolio data to clipboard for AI prompt_ action on the analysis page (experimental)
 - Improved the language localization for German (`de`)
 
 ### Fixed
diff --git a/apps/api/src/app/endpoints/ai/ai.service.ts b/apps/api/src/app/endpoints/ai/ai.service.ts
index 4cc4fde65..d07768d69 100644
--- a/apps/api/src/app/endpoints/ai/ai.service.ts
+++ b/apps/api/src/app/endpoints/ai/ai.service.ts
@@ -14,6 +14,27 @@ import type { ColumnDescriptor } from 'tablemark';
 
 @Injectable()
 export class AiService {
+  private static readonly HOLDINGS_TABLE_COLUMN_DEFINITIONS: ({
+    key:
+      | 'ALLOCATION_PERCENTAGE'
+      | 'ASSET_CLASS'
+      | 'ASSET_SUB_CLASS'
+      | 'CURRENCY'
+      | 'NAME'
+      | 'SYMBOL';
+  } & ColumnDescriptor)[] = [
+    { key: 'NAME', name: 'Name' },
+    { key: 'SYMBOL', name: 'Symbol' },
+    { key: 'CURRENCY', name: 'Currency' },
+    { key: 'ASSET_CLASS', name: 'Asset Class' },
+    { key: 'ASSET_SUB_CLASS', name: 'Asset Sub Class' },
+    {
+      align: 'right',
+      key: 'ALLOCATION_PERCENTAGE',
+      name: 'Allocation in Percentage'
+    }
+  ];
+
   public constructor(
     private readonly portfolioService: PortfolioService,
     private readonly propertyService: PropertyService
@@ -59,14 +80,10 @@ export class AiService {
       userId
     });
 
-    const holdingsTableColumns: ColumnDescriptor[] = [
-      { name: 'Name' },
-      { name: 'Symbol' },
-      { name: 'Currency' },
-      { name: 'Asset Class' },
-      { name: 'Asset Sub Class' },
-      { align: 'right', name: 'Allocation in Percentage' }
-    ];
+    const holdingsTableColumns: ColumnDescriptor[] =
+      AiService.HOLDINGS_TABLE_COLUMN_DEFINITIONS.map(({ align, name }) => {
+        return { name, align: align ?? 'left' };
+      });
 
     const holdingsTableRows = Object.values(holdings)
       .sort((a, b) => {
@@ -78,17 +95,45 @@ export class AiService {
           assetClass,
           assetSubClass,
           currency,
-          name,
+          name: label,
           symbol
         }) => {
-          return {
-            Name: name,
-            Symbol: symbol,
-            Currency: currency,
-            'Asset Class': assetClass ?? '',
-            'Asset Sub Class': assetSubClass ?? '',
-            'Allocation in Percentage': `${(allocationInPercentage * 100).toFixed(3)}%`
-          };
+          return AiService.HOLDINGS_TABLE_COLUMN_DEFINITIONS.reduce(
+            (row, { key, name }) => {
+              switch (key) {
+                case 'ALLOCATION_PERCENTAGE':
+                  row[name] = `${(allocationInPercentage * 100).toFixed(3)}%`;
+                  break;
+
+                case 'ASSET_CLASS':
+                  row[name] = assetClass ?? '';
+                  break;
+
+                case 'ASSET_SUB_CLASS':
+                  row[name] = assetSubClass ?? '';
+                  break;
+
+                case 'CURRENCY':
+                  row[name] = currency;
+                  break;
+
+                case 'NAME':
+                  row[name] = label;
+                  break;
+
+                case 'SYMBOL':
+                  row[name] = symbol;
+                  break;
+
+                default:
+                  row[name] = '';
+                  break;
+              }
+
+              return row;
+            },
+            {} as Record<string, string>
+          );
         }
       );