From 7ee64cf1ace5b0bfc78ebc8b9907e8396168b4ea Mon Sep 17 00:00:00 2001 From: Neel Date: Sun, 5 Jul 2026 02:16:17 +0530 Subject: [PATCH] Migrate GfXRayPageComponent to ChangeDetectionStrategy.OnPush with minimal changes: import ChangeDetectionStrategy and set changeDetection on the component decorator + Fix apps/client/tsconfig.editor.json: add typeRoots (match tsconfig.app.json) and remove explicit types that forced missing @types/jest / @types/node --- .../src/app/pages/portfolio/x-ray/x-ray-page.component.ts | 8 +++++++- apps/client/tsconfig.editor.json | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts index c5c4fc979c..041c79d7ac 100644 --- a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts +++ b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.ts @@ -12,7 +12,12 @@ import { hasPermission, permissions } from '@ghostfolio/common/permissions'; import { GfPremiumIndicatorComponent } from '@ghostfolio/ui/premium-indicator'; import { DataService } from '@ghostfolio/ui/services'; -import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core'; +import { + ChangeDetectionStrategy, + ChangeDetectorRef, + Component, + DestroyRef +} from '@angular/core'; import { takeUntilDestroyed } from '@angular/core/rxjs-interop'; import { IonIcon } from '@ionic/angular/standalone'; import { addIcons } from 'ionicons'; @@ -24,6 +29,7 @@ import { import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; @Component({ + changeDetection: ChangeDetectionStrategy.OnPush, imports: [ GfPremiumIndicatorComponent, GfRulesComponent, diff --git a/apps/client/tsconfig.editor.json b/apps/client/tsconfig.editor.json index 1bf3c0a745..8a9fe4859a 100644 --- a/apps/client/tsconfig.editor.json +++ b/apps/client/tsconfig.editor.json @@ -2,7 +2,7 @@ "extends": "./tsconfig.json", "include": ["**/*.ts"], "compilerOptions": { - "types": ["jest", "node"] + "typeRoots": ["../../node_modules/@types"] }, "exclude": ["jest.config.ts"] }