diff --git a/.eslintrc.json b/.eslintrc.json
index 4ea02bd33..9020c2909 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -7,7 +7,7 @@
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {
"@nx/enforce-module-boundaries": [
- "error",
+ "warn",
{
"enforceBuildableLibDependency": true,
"allow": [],
@@ -35,7 +35,7 @@
"files": ["*.ts"],
"plugins": ["eslint-plugin-import", "@typescript-eslint"],
"rules": {
- "@typescript-eslint/consistent-type-definitions": "error",
+ "@typescript-eslint/consistent-type-definitions": "warn",
"@typescript-eslint/dot-notation": "off",
"@typescript-eslint/explicit-member-accessibility": [
"off",
@@ -43,31 +43,35 @@
"accessibility": "explicit"
}
],
- "@typescript-eslint/member-ordering": "error",
+ "@typescript-eslint/member-ordering": "warn",
"@typescript-eslint/naming-convention": "off",
"@typescript-eslint/no-empty-function": "off",
- "@typescript-eslint/no-empty-interface": "error",
+ "@typescript-eslint/no-empty-interface": "warn",
"@typescript-eslint/no-inferrable-types": [
- "error",
+ "warn",
{
"ignoreParameters": true
}
],
"@typescript-eslint/no-misused-new": "error",
- "@typescript-eslint/no-non-null-assertion": "error",
+ "@typescript-eslint/no-non-null-assertion": "warn",
"@typescript-eslint/no-shadow": [
- "error",
+ "warn",
{
"hoist": "all"
}
],
- "@typescript-eslint/no-unused-expressions": "error",
- "@typescript-eslint/prefer-function-type": "error",
+ "@typescript-eslint/no-unused-expressions": "warn",
+ "@typescript-eslint/prefer-function-type": "warn",
"@typescript-eslint/unified-signatures": "error",
+ "@typescript-eslint/no-loss-of-precision": "warn",
+ "@typescript-eslint/no-var-requires": "warn",
+ "@typescript-eslint/ban-ts-comment": "warn",
+ "@typescript-eslint/ban-types": "warn",
"arrow-body-style": "off",
"constructor-super": "error",
"eqeqeq": ["error", "smart"],
- "guard-for-in": "error",
+ "guard-for-in": "warn",
"id-blacklist": "off",
"id-match": "off",
"import/no-deprecated": "warn",
@@ -105,12 +109,20 @@
"no-fallthrough": "error",
"no-new-wrappers": "error",
"no-restricted-imports": ["error", "rxjs/Rx"],
- "no-throw-literal": "error",
+ "no-throw-literal": "warn",
"no-undef-init": "error",
"no-underscore-dangle": "off",
"no-var": "error",
- "prefer-const": "error",
- "radix": "error"
+ "prefer-const": "warn",
+ "radix": "error",
+ "no-unsafe-optional-chaining": "warn",
+ "no-extra-boolean-cast": "warn",
+ "no-empty-pattern": "warn",
+ "no-useless-catch": "warn",
+ "no-unsafe-finally": "warn",
+ "no-prototype-builtins": "warn",
+ "no-async-promise-executor": "warn",
+ "no-constant-condition": "warn"
}
}
],
diff --git a/apps/client/src/app/pages/landing/landing-page.html b/apps/client/src/app/pages/landing/landing-page.html
index f726a6020..7ce938227 100644
--- a/apps/client/src/app/pages/landing/landing-page.html
+++ b/apps/client/src/app/pages/landing/landing-page.html
@@ -331,7 +331,7 @@
@for (testimonial of testimonials; track testimonial) {
-
+
) {}
}
diff --git a/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts b/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts
index 20247ef90..8a5e3afb9 100644
--- a/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts
+++ b/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts
@@ -52,7 +52,7 @@ export class FireCalculatorService {
r: number;
totalAmount: number;
}) {
- if (r == 0) {
+ if (r === 0) {
// No compound interest
return (totalAmount - P) / PMT;
} else if (totalAmount <= P) {
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index 39a9baf5c..a813fc216 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -53,7 +53,7 @@ import { Subject, Subscription } from 'rxjs';
styleUrls: ['./holdings-table.component.scss'],
templateUrl: './holdings-table.component.html'
})
-export class GfHoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
+export class GfHoldingsTableComponent implements OnChanges, OnDestroy {
@Input() baseCurrency: string;
@Input() deviceType: string;
@Input() hasPermissionToCreateActivity: boolean;
@@ -77,8 +77,6 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
public constructor(private router: Router) {}
- public ngOnInit() {}
-
public ngOnChanges() {
this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity'];
diff --git a/libs/ui/src/lib/shared/abstract-mat-form-field.ts b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
index 460b6969d..05491b8ab 100644
--- a/libs/ui/src/lib/shared/abstract-mat-form-field.ts
+++ b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
@@ -16,6 +16,7 @@ import { Subject } from 'rxjs';
@Component({
template: ''
})
+// eslint-disable-next-line @angular-eslint/component-class-suffix
export abstract class AbstractMatFormField
implements ControlValueAccessor, DoCheck, MatFormFieldControl, OnDestroy
{
diff --git a/libs/ui/src/lib/top-holdings/top-holdings.component.ts b/libs/ui/src/lib/top-holdings/top-holdings.component.ts
index 6f7695687..38ef3524d 100644
--- a/libs/ui/src/lib/top-holdings/top-holdings.component.ts
+++ b/libs/ui/src/lib/top-holdings/top-holdings.component.ts
@@ -38,7 +38,7 @@ import { Subject } from 'rxjs';
styleUrls: ['./top-holdings.component.scss'],
templateUrl: './top-holdings.component.html'
})
-export class GfTopHoldingsComponent implements OnChanges, OnDestroy, OnInit {
+export class GfTopHoldingsComponent implements OnChanges, OnDestroy {
@Input() baseCurrency: string;
@Input() locale = getLocale();
@Input() pageSize = Number.MAX_SAFE_INTEGER;
@@ -57,10 +57,6 @@ export class GfTopHoldingsComponent implements OnChanges, OnDestroy, OnInit {
private unsubscribeSubject = new Subject();
- public constructor() {}
-
- public ngOnInit() {}
-
public ngOnChanges() {
this.isLoading = true;