From 814461d8aa14e074eca1d987cee5193ddab3cacb Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Sat, 28 Mar 2026 16:58:45 +0700
Subject: [PATCH] feat(ui): resolve type errors

---
 .../historical-market-data-editor-dialog.component.ts     | 8 +++++---
 .../no-transactions-info.component.ts                     | 2 +-
 libs/ui/src/lib/shared/abstract-mat-form-field.ts         | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
index 3e5e3b2e9..0ba2b66cd 100644
--- a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
+++ b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
@@ -25,6 +25,7 @@ import { MatInputModule } from '@angular/material/input';
 import { IonIcon } from '@ionic/angular/standalone';
 import { addIcons } from 'ionicons';
 import { calendarClearOutline, refreshOutline } from 'ionicons/icons';
+import { isNil } from 'lodash';
 
 import { HistoricalMarketDataEditorDialogParams } from './interfaces/interfaces';
 
@@ -90,7 +91,8 @@ export class GfHistoricalMarketDataEditorDialogComponent implements OnInit {
   }
 
   public onUpdate() {
-    if (this.marketPrice() === undefined) {
+    const marketPrice = this.marketPrice();
+    if (isNil(marketPrice)) {
       return;
     }
 
@@ -100,8 +102,8 @@ export class GfHistoricalMarketDataEditorDialogComponent implements OnInit {
         marketData: {
           marketData: [
             {
-              date: this.data.dateString,
-              marketPrice: this.marketPrice()
+              marketPrice,
+              date: this.data.dateString
             }
           ]
         },
diff --git a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
index 8691dc998..9ca91d111 100644
--- a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
+++ b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
@@ -24,5 +24,5 @@ export class GfNoTransactionsInfoComponent {
   @HostBinding('class.has-border') @Input() hasBorder = true;
 
   public routerLinkPortfolioActivities =
-    internalRoutes.portfolio.subRoutes.activities.routerLink;
+    internalRoutes.portfolio.subRoutes?.activities.routerLink;
 }
diff --git a/libs/ui/src/lib/shared/abstract-mat-form-field.ts b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
index 628f0a659..0d547af4e 100644
--- a/libs/ui/src/lib/shared/abstract-mat-form-field.ts
+++ b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
@@ -37,7 +37,7 @@ export abstract class AbstractMatFormField<T>
   private static nextId = 0;
 
   protected constructor(
-    protected _elementRef: ElementRef,
+    protected _elementRef: ElementRef<HTMLElement>,
     protected _focusMonitor: FocusMonitor,
     public readonly ngControl: NgControl
   ) {
@@ -137,7 +137,7 @@ export abstract class AbstractMatFormField<T>
 
   public ngDoCheck() {
     if (this.ngControl) {
-      this.errorState = this.ngControl.invalid && this.ngControl.touched;
+      this.errorState = !!(this.ngControl.invalid && this.ngControl.touched);
       this.stateChanges.next();
     }
   }