From 82882bfa66f9284e1274f4aae5bff7c121e3ee8c Mon Sep 17 00:00:00 2001 From: Daniel Devaud Date: Sun, 12 May 2024 18:52:05 +0200 Subject: [PATCH] Fix null handling --- .../constantPortfolioReturn/portfolio-calculator.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/api/src/app/portfolio/calculator/constantPortfolioReturn/portfolio-calculator.ts b/apps/api/src/app/portfolio/calculator/constantPortfolioReturn/portfolio-calculator.ts index 49d6d60b2..f47c27610 100644 --- a/apps/api/src/app/portfolio/calculator/constantPortfolioReturn/portfolio-calculator.ts +++ b/apps/api/src/app/portfolio/calculator/constantPortfolioReturn/portfolio-calculator.ts @@ -217,9 +217,9 @@ export class CPRPortfolioCalculator extends TWRPortfolioCalculator { ) }; } - if (!currentPrice || !previousPrice) { + if (previousPrice === undefined || currentPrice === undefined) { Logger.warn( - `Missing historical market data for ${holding} (${!currentPrice ? date : previousDate}})`, + `Missing historical market data for ${holding} (${previousPrice === undefined ? previousDate : date}})`, 'PortfolioCalculator' ); return {