From 82f645750c316bbe326ab692eee7eb4fcbf96207 Mon Sep 17 00:00:00 2001 From: Thomas <4159106+dtslvr@users.noreply.github.com> Date: Thu, 30 Dec 2021 17:29:59 +0100 Subject: [PATCH] Refactor attributes and routes --- apps/client/src/app/app-routing.module.ts | 14 ++--- .../home-holdings/home-holdings.html | 4 +- .../position-detail-dialog.html | 6 +- .../app/pages/portfolio/portfolio-page.html | 22 +++---- .../create-or-update-transaction-dialog.html | 4 +- .../transactions/transactions-page.html | 14 ++--- .../activities-table.component.html | 18 +++--- .../activities-table.component.ts | 58 +++++++++---------- .../no-transactions-info.component.html | 4 +- 9 files changed, 71 insertions(+), 73 deletions(-) diff --git a/apps/client/src/app/app-routing.module.ts b/apps/client/src/app/app-routing.module.ts index 31521e686..314a89bdb 100644 --- a/apps/client/src/app/app-routing.module.ts +++ b/apps/client/src/app/app-routing.module.ts @@ -66,6 +66,13 @@ const routes: Routes = [ (m) => m.PortfolioPageModule ) }, + { + path: 'portfolio/activities', + loadChildren: () => + import('./pages/portfolio/transactions/transactions-page.module').then( + (m) => m.TransactionsPageModule + ) + }, { path: 'portfolio/allocations', loadChildren: () => @@ -87,13 +94,6 @@ const routes: Routes = [ (m) => m.ReportPageModule ) }, - { - path: 'portfolio/transactions', - loadChildren: () => - import('./pages/portfolio/transactions/transactions-page.module').then( - (m) => m.TransactionsPageModule - ) - }, { path: 'pricing', loadChildren: () => diff --git a/apps/client/src/app/components/home-holdings/home-holdings.html b/apps/client/src/app/components/home-holdings/home-holdings.html index 03232d01a..ccc2ed73f 100644 --- a/apps/client/src/app/components/home-holdings/home-holdings.html +++ b/apps/client/src/app/components/home-holdings/home-holdings.html @@ -25,8 +25,8 @@ class="mt-3" i18n mat-button - [routerLink]="['/portfolio', 'transactions']" - >Manage Transactions...Manage Activities... diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html index 18a46fecd..00d949263 100644 --- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html +++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html @@ -127,16 +127,16 @@ diff --git a/apps/client/src/app/pages/portfolio/portfolio-page.html b/apps/client/src/app/pages/portfolio/portfolio-page.html index 2b43efedb..6644e9340 100644 --- a/apps/client/src/app/pages/portfolio/portfolio-page.html +++ b/apps/client/src/app/pages/portfolio/portfolio-page.html @@ -3,16 +3,16 @@
-

Transactions

-

Manage your transactions.

+

Activities

+

Manage your activities.

- Open Transactions → + Open Activities +

@@ -31,12 +31,12 @@

- Open Allocations → + Open Allocations +

@@ -57,12 +57,12 @@

- Open Analysis → + Open Analysis +

@@ -84,12 +84,12 @@

- Open X-ray → + Open X-ray +

diff --git a/apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html b/apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html index f0e12ebc8..f2dbd54f8 100644 --- a/apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html +++ b/apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html @@ -1,6 +1,6 @@
-

Update transaction

-

Add transaction

+

Update activity

+

Add activity

diff --git a/apps/client/src/app/pages/portfolio/transactions/transactions-page.html b/apps/client/src/app/pages/portfolio/transactions/transactions-page.html index 5096959ac..6674025fe 100644 --- a/apps/client/src/app/pages/portfolio/transactions/transactions-page.html +++ b/apps/client/src/app/pages/portfolio/transactions/transactions-page.html @@ -1,20 +1,20 @@
-

Transactions

+

Activities

diff --git a/libs/ui/src/lib/activities-table/activities-table.component.html b/libs/ui/src/lib/activities-table/activities-table.component.html index 4564e6448..10524d822 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.html +++ b/libs/ui/src/lib/activities-table/activities-table.component.html @@ -230,14 +230,14 @@ - + - - - - @@ -305,7 +305,7 @@
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts index 8df76d9d2..0cbde8228 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.ts +++ b/libs/ui/src/lib/activities-table/activities-table.component.ts @@ -36,22 +36,22 @@ const SEARCH_STRING_SEPARATOR = ','; templateUrl: './activities-table.component.html' }) export class ActivitiesTableComponent implements OnChanges, OnDestroy { + @Input() activities: OrderWithAccount[]; @Input() baseCurrency: string; @Input() deviceType: string; - @Input() hasPermissionToCreateOrder: boolean; + @Input() hasPermissionToCreateActivity: boolean; @Input() hasPermissionToFilter = true; - @Input() hasPermissionToImportOrders: boolean; + @Input() hasPermissionToImportActivities: boolean; @Input() hasPermissionToOpenDetails = true; @Input() locale: string; @Input() showActions: boolean; @Input() showSymbolColumn = true; - @Input() transactions: OrderWithAccount[]; + @Output() activityDeleted = new EventEmitter(); + @Output() activityToClone = new EventEmitter(); + @Output() activityToUpdate = new EventEmitter(); @Output() export = new EventEmitter(); @Output() import = new EventEmitter(); - @Output() transactionDeleted = new EventEmitter(); - @Output() transactionToClone = new EventEmitter(); - @Output() transactionToUpdate = new EventEmitter(); @ViewChild('autocomplete') matAutocomplete: MatAutocomplete; @ViewChild('searchInput') searchInput: ElementRef; @@ -148,8 +148,8 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { this.isLoading = true; - if (this.transactions) { - this.dataSource = new MatTableDataSource(this.transactions); + if (this.activities) { + this.dataSource = new MatTableDataSource(this.activities); this.dataSource.filterPredicate = (data, filter) => { const dataString = this.getFilterableValues(data) .join(' ') @@ -167,13 +167,15 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { } } - public onDeleteTransaction(aId: string) { - const confirmation = confirm( - 'Do you really want to delete this transaction?' - ); + public onCloneActivity(aActivity: OrderWithAccount) { + this.activityToClone.emit(aActivity); + } + + public onDeleteActivity(aId: string) { + const confirmation = confirm('Do you really want to delete this activity?'); if (confirmation) { - this.transactionDeleted.emit(aId); + this.activityDeleted.emit(aId); } } @@ -191,12 +193,8 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { }); } - public onUpdateTransaction(aTransaction: OrderWithAccount) { - this.transactionToUpdate.emit(aTransaction); - } - - public onCloneTransaction(aTransaction: OrderWithAccount) { - this.transactionToClone.emit(aTransaction); + public onUpdateActivity(aActivity: OrderWithAccount) { + this.activityToUpdate.emit(aActivity); } public ngOnDestroy() { @@ -213,7 +211,7 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { this.placeholder = lowercaseSearchKeywords.length <= 0 ? SEARCH_PLACEHOLDER : ''; - this.allFilters = this.getSearchableFieldValues(this.transactions).filter( + this.allFilters = this.getSearchableFieldValues(this.activities).filter( (item) => { return !lowercaseSearchKeywords.includes(item.trim().toLowerCase()); } @@ -222,11 +220,11 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { this.filters$.next(this.allFilters); } - private getSearchableFieldValues(transactions: OrderWithAccount[]): string[] { + private getSearchableFieldValues(activities: OrderWithAccount[]): string[] { const fieldValues = new Set(); - for (const transaction of transactions) { - this.getFilterableValues(transaction, fieldValues); + for (const activity of activities) { + this.getFilterableValues(activity, fieldValues); } return [...fieldValues] @@ -251,15 +249,15 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { } private getFilterableValues( - transaction: OrderWithAccount, + activity: OrderWithAccount, fieldValues: Set = new Set() ): string[] { - fieldValues.add(transaction.currency); - fieldValues.add(transaction.symbol); - fieldValues.add(transaction.type); - fieldValues.add(transaction.Account?.name); - fieldValues.add(transaction.Account?.Platform?.name); - fieldValues.add(format(transaction.date, 'yyyy')); + fieldValues.add(activity.currency); + fieldValues.add(activity.symbol); + fieldValues.add(activity.type); + fieldValues.add(activity.Account?.name); + fieldValues.add(activity.Account?.Platform?.name); + fieldValues.add(format(activity.date, 'yyyy')); return [...fieldValues].filter((item) => { return item !== undefined; diff --git a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.html b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.html index bb3ce1238..9f30d437a 100644 --- a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.html +++ b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.html @@ -5,10 +5,10 @@ - Time to add your first transaction. + Time to add your first activity.