From 82f645750c316bbe326ab692eee7eb4fcbf96207 Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Thu, 30 Dec 2021 17:29:59 +0100
Subject: [PATCH] Refactor attributes and routes
---
apps/client/src/app/app-routing.module.ts | 14 ++---
.../home-holdings/home-holdings.html | 4 +-
.../position-detail-dialog.html | 6 +-
.../app/pages/portfolio/portfolio-page.html | 22 +++----
.../create-or-update-transaction-dialog.html | 4 +-
.../transactions/transactions-page.html | 14 ++---
.../activities-table.component.html | 18 +++---
.../activities-table.component.ts | 58 +++++++++----------
.../no-transactions-info.component.html | 4 +-
9 files changed, 71 insertions(+), 73 deletions(-)
diff --git a/apps/client/src/app/app-routing.module.ts b/apps/client/src/app/app-routing.module.ts
index 31521e686..314a89bdb 100644
--- a/apps/client/src/app/app-routing.module.ts
+++ b/apps/client/src/app/app-routing.module.ts
@@ -66,6 +66,13 @@ const routes: Routes = [
(m) => m.PortfolioPageModule
)
},
+ {
+ path: 'portfolio/activities',
+ loadChildren: () =>
+ import('./pages/portfolio/transactions/transactions-page.module').then(
+ (m) => m.TransactionsPageModule
+ )
+ },
{
path: 'portfolio/allocations',
loadChildren: () =>
@@ -87,13 +94,6 @@ const routes: Routes = [
(m) => m.ReportPageModule
)
},
- {
- path: 'portfolio/transactions',
- loadChildren: () =>
- import('./pages/portfolio/transactions/transactions-page.module').then(
- (m) => m.TransactionsPageModule
- )
- },
{
path: 'pricing',
loadChildren: () =>
diff --git a/apps/client/src/app/components/home-holdings/home-holdings.html b/apps/client/src/app/components/home-holdings/home-holdings.html
index 03232d01a..ccc2ed73f 100644
--- a/apps/client/src/app/components/home-holdings/home-holdings.html
+++ b/apps/client/src/app/components/home-holdings/home-holdings.html
@@ -25,8 +25,8 @@
class="mt-3"
i18n
mat-button
- [routerLink]="['/portfolio', 'transactions']"
- >Manage Transactions...Manage Activities...
diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
index 18a46fecd..00d949263 100644
--- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
+++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
@@ -127,16 +127,16 @@
Manage your transactions.
+Manage your activities.
- Open Allocations →
+ Open Allocations
+