Browse Source

Refactoring

pull/4256/head
Thomas Kaul 7 months ago
parent
commit
8894d9acb7
  1. 12
      libs/ui/src/lib/tags-selector/tags-selector.component.ts

12
libs/ui/src/lib/tags-selector/tags-selector.component.ts

@ -50,9 +50,9 @@ export class GfTagsSelectorComponent implements OnInit, OnChanges, OnDestroy {
@ViewChild('tagInput') tagInput: ElementRef<HTMLInputElement>; @ViewChild('tagInput') tagInput: ElementRef<HTMLInputElement>;
public filteredOptions: Subject<Tag[]> = new BehaviorSubject([]); public filteredOptions: Subject<Tag[]> = new BehaviorSubject([]);
public readonly separatorKeysCodes: number[] = [COMMA, ENTER];
public readonly tagInputControl = new FormControl(''); public readonly tagInputControl = new FormControl('');
public readonly tagsSelected = signal<Tag[]>([]); public readonly tagsSelected = signal<Tag[]>([]);
public readonly separatorKeysCodes: number[] = [COMMA, ENTER];
private unsubscribeSubject = new Subject<void>(); private unsubscribeSubject = new Subject<void>();
@ -74,11 +74,6 @@ export class GfTagsSelectorComponent implements OnInit, OnChanges, OnDestroy {
this.updateFilters(); this.updateFilters();
} }
public ngOnDestroy() {
this.unsubscribeSubject.next();
this.unsubscribeSubject.complete();
}
public onAddTag(event: MatAutocompleteSelectedEvent) { public onAddTag(event: MatAutocompleteSelectedEvent) {
const tag = this.tagsAvailable.find(({ id }) => { const tag = this.tagsAvailable.find(({ id }) => {
return id === event.option.value; return id === event.option.value;
@ -104,6 +99,11 @@ export class GfTagsSelectorComponent implements OnInit, OnChanges, OnDestroy {
this.updateFilters(); this.updateFilters();
} }
public ngOnDestroy() {
this.unsubscribeSubject.next();
this.unsubscribeSubject.complete();
}
private filterTags(query: string = ''): Tag[] { private filterTags(query: string = ''): Tag[] {
const tags = this.tagsSelected() ?? []; const tags = this.tagsSelected() ?? [];
const tagIds = tags.map(({ id }) => { const tagIds = tags.map(({ id }) => {

Loading…
Cancel
Save