Browse Source
Task/set change detection strategy to OnPush in FIRE page (#7252)
* Set change detection strategy to OnPush
* Update changelog
pull/7256/head^2
Archit Goyal
1 week ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
13 additions and
2 deletions
-
CHANGELOG.md
-
apps/client/src/app/pages/portfolio/fire/fire-page.component.ts
|
|
|
@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. |
|
|
|
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), |
|
|
|
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). |
|
|
|
|
|
|
|
## Unreleased |
|
|
|
|
|
|
|
### Changed |
|
|
|
|
|
|
|
- Set the change detection strategy to `OnPush` in the _FIRE_ page |
|
|
|
|
|
|
|
## 3.21.0 - 2026-07-05 |
|
|
|
|
|
|
|
### Added |
|
|
|
|
|
|
|
@ -14,6 +14,7 @@ import { GfValueComponent } from '@ghostfolio/ui/value'; |
|
|
|
|
|
|
|
import { CommonModule } from '@angular/common'; |
|
|
|
import { |
|
|
|
ChangeDetectionStrategy, |
|
|
|
ChangeDetectorRef, |
|
|
|
Component, |
|
|
|
computed, |
|
|
|
@ -29,6 +30,7 @@ import { DeviceDetectorService } from 'ngx-device-detector'; |
|
|
|
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; |
|
|
|
|
|
|
|
@Component({ |
|
|
|
changeDetection: ChangeDetectionStrategy.OnPush, |
|
|
|
imports: [ |
|
|
|
CommonModule, |
|
|
|
FormsModule, |
|
|
|
@ -89,6 +91,7 @@ export class GfFirePageComponent implements OnInit { |
|
|
|
: 0 |
|
|
|
} |
|
|
|
}; |
|
|
|
|
|
|
|
if (this.user.subscription?.type === SubscriptionType.Basic) { |
|
|
|
this.fireWealth = { |
|
|
|
today: { |
|
|
|
@ -107,6 +110,8 @@ export class GfFirePageComponent implements OnInit { |
|
|
|
.pipe(takeUntilDestroyed(this.destroyRef)) |
|
|
|
.subscribe((impersonationId) => { |
|
|
|
this.hasImpersonationId = !!impersonationId; |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
}); |
|
|
|
|
|
|
|
this.safeWithdrawalRateControl.valueChanges |
|
|
|
@ -135,9 +140,9 @@ export class GfFirePageComponent implements OnInit { |
|
|
|
); |
|
|
|
|
|
|
|
this.calculateWithdrawalRates(); |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
} |
|
|
|
|
|
|
|
this.changeDetectorRef.markForCheck(); |
|
|
|
}); |
|
|
|
} |
|
|
|
|
|
|
|
|