From 8a88b1b1af03e91bb78032329d92a2ef856a1390 Mon Sep 17 00:00:00 2001
From: tobikugel <tobiaskugel@outlook.com>
Date: Tue, 11 Mar 2025 11:22:15 -0300
Subject: [PATCH] feat: prevent menu from closing until loading completes

---
 .../analysis/analysis-page.component.ts       | 12 +++-
 .../portfolio/analysis/analysis-page.html     | 68 ++++++++++---------
 2 files changed, 47 insertions(+), 33 deletions(-)

diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
index 28c0b9c0e..06f3ee038 100644
--- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
@@ -16,7 +16,14 @@ import type { AiPromptMode, GroupBy } from '@ghostfolio/common/types';
 import { translate } from '@ghostfolio/ui/i18n';
 
 import { Clipboard } from '@angular/cdk/clipboard';
-import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
+import {
+  ChangeDetectorRef,
+  Component,
+  OnDestroy,
+  OnInit,
+  ViewChild
+} from '@angular/core';
+import { MatMenuTrigger } from '@angular/material/menu';
 import { MatSnackBar } from '@angular/material/snack-bar';
 import { SymbolProfile } from '@prisma/client';
 import { isNumber, sortBy } from 'lodash';
@@ -32,6 +39,7 @@ import { takeUntil } from 'rxjs/operators';
   standalone: false
 })
 export class AnalysisPageComponent implements OnDestroy, OnInit {
+  @ViewChild(MatMenuTrigger) actionsMenuButton!: MatMenuTrigger;
   public benchmark: Partial<SymbolProfile>;
   public benchmarkDataItems: HistoricalDataItem[] = [];
   public benchmarks: Partial<SymbolProfile>[];
@@ -163,6 +171,8 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
           .subscribe(() => {
             window.open('https://duck.ai', '_blank');
           });
+
+        this.actionsMenuButton.closeMenu();
       });
   }
 
diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
index 3464562a9..ae8196183 100644
--- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
+++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
@@ -5,6 +5,7 @@
       <div class="col-lg">
         <div class="d-flex justify-content-end">
           <button
+            #actionsMenuButton
             class="mx-1 no-min-width px-2"
             mat-stroked-button
             [matMenuTriggerFor]="actionsMenu"
@@ -13,38 +14,41 @@
             <ion-icon name="ellipsis-vertical" />
           </button>
           <mat-menu #actionsMenu="matMenu" class="wide-menu" xPosition="before">
-            <button
-              mat-menu-item
-              [disabled]="!hasPermissionToReadAiPrompt"
-              (click)="onCopyPromptToClipboard('portfolio')"
-            >
-              <span class="align-items-center d-flex">
-                @if (user?.subscription?.type === 'Basic') {
-                  <gf-premium-indicator class="mr-2" />
-                } @else {
-                  <ion-icon class="mr-2" name="copy-outline" />
-                }
-                <ng-container i18n
-                  >Copy portfolio data to clipboard for AI prompt</ng-container
-                >
-              </span>
-            </button>
-            <button
-              mat-menu-item
-              [disabled]="!hasPermissionToReadAiPrompt"
-              (click)="onCopyPromptToClipboard('analysis')"
-            >
-              <span class="align-items-center d-flex">
-                @if (user?.subscription?.type === 'Basic') {
-                  <gf-premium-indicator class="mr-2" />
-                } @else {
-                  <ion-icon class="mr-2" name="copy-outline" />
-                }
-                <ng-container i18n
-                  >Copy AI prompt to clipboard for analysis</ng-container
-                >
-              </span>
-            </button>
+            <div (click)="$event.stopPropagation()">
+              <button
+                mat-menu-item
+                [disabled]="!hasPermissionToReadAiPrompt"
+                (click)="onCopyPromptToClipboard('portfolio')"
+              >
+                <span class="align-items-center d-flex">
+                  @if (user?.subscription?.type === 'Basic') {
+                    <gf-premium-indicator class="mr-2" />
+                  } @else {
+                    <ion-icon class="mr-2" name="copy-outline" />
+                  }
+                  <ng-container i18n
+                    >Copy portfolio data to clipboard for AI
+                    prompt</ng-container
+                  >
+                </span>
+              </button>
+              <button
+                mat-menu-item
+                [disabled]="!hasPermissionToReadAiPrompt"
+                (click)="onCopyPromptToClipboard('analysis')"
+              >
+                <span class="align-items-center d-flex">
+                  @if (user?.subscription?.type === 'Basic') {
+                    <gf-premium-indicator class="mr-2" />
+                  } @else {
+                    <ion-icon class="mr-2" name="copy-outline" />
+                  }
+                  <ng-container i18n
+                    >Copy AI prompt to clipboard for analysis</ng-container
+                  >
+                </span>
+              </button>
+            </div>
           </mat-menu>
         </div>
       </div>