From 8b08a1bf2ba22a573f8af1fbc3ee76020a49431e Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Thu, 29 Feb 2024 20:08:04 +0100
Subject: [PATCH] Minor improvements

---
 .../data-enhancer/yahoo-finance/yahoo-finance.service.ts  | 8 +++-----
 .../data-provider/yahoo-finance/yahoo-finance.service.ts  | 2 +-
 test/import/ok-btc.csv                                    | 3 ---
 test/import/ok-isin.csv                                   | 3 ---
 4 files changed, 4 insertions(+), 12 deletions(-)
 delete mode 100644 test/import/ok-btc.csv
 delete mode 100644 test/import/ok-isin.csv

diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
index fc7c048a2..c6edef0ca 100644
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -196,7 +196,9 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
         shortName: assetProfile.price.shortName,
         symbol: assetProfile.price.symbol
       });
-      response.symbol = assetProfile.price.symbol;
+      response.symbol = this.convertFromYahooFinanceSymbol(
+        assetProfile.price.symbol
+      );
 
       if (assetSubClass === AssetSubClass.MUTUALFUND) {
         response.sectors = [];
@@ -230,10 +232,6 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
         }
       }
 
-      response.symbol = this.convertFromYahooFinanceSymbol(
-        assetProfile.price.symbol
-      );
-
       const url = assetProfile.summaryProfile?.website;
       if (url) {
         response.url = url;
diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
index 6dc9af902..c55da2597 100644
--- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
@@ -38,7 +38,7 @@ export class YahooFinanceService implements DataProviderInterface {
   }: {
     symbol: string;
   }): Promise<Partial<SymbolProfile>> {
-    return await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
+    return this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
   }
 
   public getDataProviderInfo(): DataProviderInfo {
diff --git a/test/import/ok-btc.csv b/test/import/ok-btc.csv
deleted file mode 100644
index efa7eb485..000000000
--- a/test/import/ok-btc.csv
+++ /dev/null
@@ -1,3 +0,0 @@
-Date,DataSource,Code,Currency,Price,Quantity,Action,Fee
-12/12/2021,YAHOO,BTCUSD,USD,44558.42,1,buy,0
-12/12/2021,YAHOO,BTC-USD,USD,44558.42,1,buy,0
\ No newline at end of file
diff --git a/test/import/ok-isin.csv b/test/import/ok-isin.csv
deleted file mode 100644
index 33a0aba7a..000000000
--- a/test/import/ok-isin.csv
+++ /dev/null
@@ -1,3 +0,0 @@
-Date,Action,DataSource,Code,Quantity,unitPrice,Fee,Currency
-2024-02-25,buy,YAHOO,DK0060442556,5,275.10,0,DKK
-2024-02-25,buy,YAHOO,SPIC25KL.CO,5,275.10,0,DKK